Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Laravel 5.6 #71

Open
gemal opened this issue Mar 8, 2018 · 7 comments
Open

Support for Laravel 5.6 #71

gemal opened this issue Mar 8, 2018 · 7 comments

Comments

@gemal
Copy link

gemal commented Mar 8, 2018

Any chance for support for Laravel 5.6?
@potsky
Copy link
Owner

potsky commented Mar 13, 2018

No more coding this year guys. Sorry.

@gemal
Copy link
Author

gemal commented Mar 13, 2018

Do you accept pull requests?

@potsky
Copy link
Owner

potsky commented Mar 13, 2018

Yes sure. I can create the 5.6 branch and let you make a PR.

@potsky
Copy link
Owner

potsky commented Mar 13, 2018

Branch created

@potsky
Copy link
Owner

potsky commented Mar 13, 2018

Want to be a collaborator @gemal ? Given that you are the guy who gave me motivation to build Pimp My Log, I can give you push access to the repo to manage it if you know what you do ! Tell me ;-)

@gemal
Copy link
Author

gemal commented Mar 21, 2018

Sorry but I will not have the time for that. Hopefully someone else steps up so we can get this one on Laravel 5.6. Perhaps it's just a simple change to composer.json?
Do you know of any problems?

@smarquina
Copy link

This PR #70 looks like solves new requirements. Will you @potsky accept that PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gemal @potsky @smarquina