Laravel 5.6 compatibility #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now all tests are passing except the ones using Microsoft's Translator Service: |
|
Any plans on merging this? |
|
Hi ! Does anyone want to be a collaborator on the repository to manage it |
|
@limenet you are already involved. Go for it! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 5.6 is out and it doesn't seem like much has changed: https://laravel.com/docs/5.6/upgrade except PHP >= 7.1.3 being required which results in the build on PHP 7.0 to fail.
It'd be great if this package supported Laravel 5.6!
I'm not sure against which branch I should send the PR to adhere to your versioning scheme: https://github.com/potsky/laravel-localization-helpers#1-installation
Let me know if you'd like me to make any changes!
Also, please see #69 (comment) for why I upgraded
satooshi/php-coveralls.