Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From AppCache to Service Workers #207

Closed
Voles opened this issue Jan 9, 2018 · 12 comments
Closed

From AppCache to Service Workers #207

Voles opened this issue Jan 9, 2018 · 12 comments

Comments

@Voles
Copy link
Contributor

Voles commented Jan 9, 2018

At the moment we're suggesting users to use broccoli-manifest to setup an Offline First app using Ember Pouch.

But the application cache has been removed from the Web standards. I have been using Ember Service Worker instead and it seems to be the way to go for future-proof-offline-first-web-apps.

Would the team be interested if I'd update the Offline-First section using Ember Service Worker?

Btw, thanks for everyone's work on this extremely useful plugin 👏 🌻

@broerse
Copy link
Collaborator

broerse commented Jan 10, 2018

@Voles Good point. We would like it very much if you work on the Offline-First section. Perhaps also mention https://github.com/broerse/ember-cli-blog/blob/master/ember-cli-build.js#L14

We are working hard to get v5.0.0 out of Beta so this is the right time to improve the readme.

@Voles
Copy link
Contributor Author

Voles commented Jan 10, 2018

@broerse I was a little too quick here. It looks like iOS 11.x does not yet support SW.

References:

I don't think we should encourage users migrating to SW while support is not (yet) broadly covered. Let's keep an eye on the iOS 12 release to see if we can move this forward by then.

@jaystarshot
Copy link

Hey I am new to Opensource having some experience about serviceworkers ,can I help?

@broerse
Copy link
Collaborator

broerse commented Jan 11, 2018

@BlackTrident Help is always welcome. I agree with @Voles that pushing people to SW while safari is not ready yet perhaps we should not encourage it in this module now.

@jkleinsc what do you think. Should we encourage SW here now?

@jkleinsc
Copy link
Collaborator

I think SW should be encouraged. Safari has service workers available in their technology preview (eg see https://webkit.org/blog/8060/release-notes-for-safari-technology-preview-47/). We could still leave in the section about appcache with something like "if you need to support browsers that currently don't have service workers available, you can use Application Cache via broccoli-manifest as a fallback."

@broerse
Copy link
Collaborator

broerse commented Jan 11, 2018

@Voles can you create something like @jkleinsc suggested?

@Voles
Copy link
Contributor Author

Voles commented Jan 12, 2018

@jkleinsc @broerse while it is indeed available in Safari TP, I expect it only to be available on iOS in September (when I expect them to release iOS 12).

What about I update that section and mention both scenarios? We could recommend AppCache for now but also mention SW and the fact that it currently does not yet work on Safari for iOS?

@jkleinsc thanks for that link to Safari TP! Do you know more about the iOS releases and if SW might land sooner?

@broerse
Copy link
Collaborator

broerse commented Jan 12, 2018

What about I update that section and mention both scenarios?

I would like that.

@jkleinsc
Copy link
Collaborator

@Voles I don't have any more information about when it will land in iOS.
I would recommend that when the document is updated, it should advocate to use service workers if available and use appcache as a fallback. Service worker enabled browsers ignore appcache if a service worker is available so enabling both in your application is recommended if you are supporting a wide variety of browsers, particularly because the effort to implement both is fairly minimal.

Voles pushed a commit to Voles/ember-pouch that referenced this issue Jan 14, 2018
Voles pushed a commit to Voles/ember-pouch that referenced this issue Jan 14, 2018
Voles pushed a commit to Voles/ember-pouch that referenced this issue Jan 14, 2018
@Voles
Copy link
Contributor Author

Voles commented Jan 14, 2018

I've updated the Offline First instructions based on what we discussed here. See #209.

@BlackTrident @broerse @jkleinsc feedback is very much welcome!

@broerse
Copy link
Collaborator

broerse commented Jan 14, 2018

@Voles Just merged this. Thanks! @BlackTrident if you want to add or change something please make a new PR. We are always open for suggestions. If you need help with that, because you say you are new to Opensource, please let me know.

@Voles
Copy link
Contributor Author

Voles commented Jan 15, 2018

@broerse thanks for your quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants