Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some jobs on Travis Trusty #187

Merged
merged 15 commits into from Nov 9, 2017
Merged

Fix some jobs on Travis Trusty #187

merged 15 commits into from Nov 9, 2017

Conversation

backspace
Copy link
Collaborator

This is a pretty hackish solution to this problem, also discussed here: ember-try uses the presence of a yarn command to determine whether to yarn install. Something was going wrong with the yarn install on the ember-release and ember-beta scenarios.

This fixes those scenarios but then breaks the ones before them, the inverse of what was happening!

I’m going to ask over on the ember-try thread about whether it’s possible to bypass Yarn more elegantly. I’ll also see if I can override Ember CLI’s built-in ember-try version with an older one that doesn’t use Yarn.

Surely this won’t work. Better to add something to the path?
Will _this_ work? 🤔
Will this override the Ember CLI one? 🤔
@backspace
Copy link
Collaborator Author

backspace commented Jul 27, 2017

Adding an older ember-try to the package.json has fixed the problems on Trusty because 0.2.11 doesn’t try to use yarn install. I’m not a huge fan of this workaround, hopefully my query in ember-try will yield another possibility.

@backspace
Copy link
Collaborator Author

Incidentally, Trusty has PhantomJS 2.0.0 installed, so we could perhaps abandon the bower.json file entirely because I believe it doesn’t need the polyfill.

Or should we switch to headless Chrome or Firefox?

@broerse
Copy link
Collaborator

broerse commented Jul 27, 2017

I have seen somewhere that Ember will swap PhantomJS for headless Chrome in version 16 but can find where I have seen that. So I think switching to headless Chrome is the future anyway. We could do that. See also: https://embermap.com/notes/59-ember-tests-with-headless-chrome

@broerse
Copy link
Collaborator

broerse commented Jul 27, 2017

It will be in ember-cli 15.0 See ember-cli/ember-cli#7148

@backspace
Copy link
Collaborator Author

ah, not too far away! Maybe it makes sense to just wait for that release and do it all at once.

I have a preliminary PR on ember-try to stop trying to use Yarn when there’s no lockfile, I’ll proceed with this fix once that issue is fixed.

@broerse
Copy link
Collaborator

broerse commented Aug 29, 2017

@backspace now your PR is merged do we wait for ember-cli 15.0 or can this be fixed now?

@backspace
Copy link
Collaborator Author

I don’t think a new ember-try version has been released yet, so it won’t be included in Ember CLI, right? We could override the version but that seems annoying…???

@broerse
Copy link
Collaborator

broerse commented Aug 29, 2017

I assumed it was released also. Don't overwrite the version for this. We will wait. Perhaps fix this together with #110

@backspace
Copy link
Collaborator Author

A new version of ember-try was released, so I continued with this. I ended up just updating Ember CLI, which brought along the new .travis.yml blueprint that switches to Trusty. I removed the Bower thing for the PhantomJS Object.assign polyfill.

What do you think, @broerse or interested parties? This grew beyond what I originally started the PR for, I can adjust as desired.

@broerse
Copy link
Collaborator

broerse commented Nov 9, 2017

Looking good @backspace ! I think no need to adjust this. But can you squash this so we I can see more clear what will be merged?

@backspace
Copy link
Collaborator Author

GitHub lets you squash and merge from a PR now:

image

So whatever you see on the Files changed tab is what the commit will look like. But if you want, I can still squash locally.

@broerse
Copy link
Collaborator

broerse commented Nov 9, 2017

I will take the change ;-)

@broerse broerse merged commit 9288e9c into master Nov 9, 2017
@broerse broerse deleted the test-trusty branch November 9, 2017 15:44
@jlami
Copy link
Collaborator

jlami commented Nov 9, 2017

I'm affraid the changes to the ember-try config have removed the ember-data versions.
See here: https://travis-ci.org/pouchdb-community/ember-pouch/jobs/298350042#L3176
This is the job with ember 2.16.2, but ember-data is not changed.

I think ember-data still needs to be added to the ember-try setup like before: https://github.com/pouchdb-community/ember-pouch/pull/187/files#diff-d20f4baf61c4397c467d6218d0ba6a04L25

@backspace
Copy link
Collaborator Author

eep sorry about that, I can look into it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants