Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore same revision changes #189

Merged
merged 1 commit into from Jan 12, 2018
Merged

Ignore same revision changes #189

merged 1 commit into from Jan 12, 2018

Conversation

jlami
Copy link
Collaborator

@jlami jlami commented Jul 27, 2017

Possible solution for #188

Will look for a better solution

Possible solution for #188

Will look for a better solution
@broerse
Copy link
Collaborator

broerse commented Jul 27, 2017

Should I merge this?

@jlami
Copy link
Collaborator Author

jlami commented Jul 27, 2017

Not yet I think, this is a temporary fix to see if this is the way to go. I have an extra issue open on ember-data to see if this is something they can fix.

@tobiasWenger
Copy link

@jlami Could you find out if it is the way to go? I would like to have this "hack" merged into master.

@jlami
Copy link
Collaborator Author

jlami commented Jan 11, 2018

@tobiasWenger Do you have experience with this hack in place. I must admit that I have not tested it as thoroughly as I wanted yet.

@tobiasWenger
Copy link

@jlami My app is still in the development phase but up to now I did not encounter any problems. I added this hack locally to the newest version (4.3.0) to test it and it seams to work fine.

@jlami
Copy link
Collaborator Author

jlami commented Jan 12, 2018

Let's use this then and we will see if there are any problems or if we can even improve on this.

@jlami jlami merged commit 3d06dbf into master Jan 12, 2018
@jlami jlami deleted the changes-same-revision-hack branch January 12, 2018 13:21
@tobiasWenger
Copy link

@jlami Many thanks and I really appreciate all of your work. I would be lost without people like you. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants