Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow usage of limit parameter in pouchdb adapter queries #193

Merged
merged 2 commits into from Sep 16, 2017
Merged

allow usage of limit parameter in pouchdb adapter queries #193

merged 2 commits into from Sep 16, 2017

Conversation

akatov
Copy link
Contributor

@akatov akatov commented Sep 8, 2017

No description provided.

@broerse
Copy link
Collaborator

broerse commented Sep 12, 2017

@akatov Can you add something to the readme about this?

@akatov
Copy link
Contributor Author

akatov commented Sep 13, 2017

sure. will do this and a rebase as well

@afinne
Copy link

afinne commented Sep 15, 2017

It could be an idea to also include skip?

What we did in our project was:

    queryParams = {
      selector: selector
      limit: query.limit ? 100
      skip: query.skip
    }
    queryParams.sort = @_buildSort(query.sort) unless Ember.isEmpty(query.sort)

Note, we use coffeescript

@akatov
Copy link
Contributor Author

akatov commented Sep 15, 2017

@afinne good idea! @broerse I'm happy to make another PR for the skip parameter

@akatov
Copy link
Contributor Author

akatov commented Sep 15, 2017

see #198 for skip parameter

@broerse
Copy link
Collaborator

broerse commented Sep 16, 2017

@akatov Thanks will merge both today.

@broerse broerse merged commit 3607fee into pouchdb-community:master Sep 16, 2017
@akatov akatov deleted the allow-query-limit branch November 7, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants