Mono repo take three #168

garrensmith · 2017-02-16T16:04:00Z

This is my third and final push on getting this mono-repo. I've imported express-server in with full git history.

Also related to #36. Also fixes #51 because we now use the pouchdb-all-dbs plugin.

Built from https://github.com/apache/couchdb-fauxton Looks and feels a lot nicer now, although many of the sidebar options don't work (e.g. config).

Also update README to note Fauxton branding and PouchDB.defaults API.

Notable additions: * startTime in db.info() * multipart/related support for PUT * changes with feed=continuous actually does a continuous feed like it's supposed to

Also clean up the multiparty usage a bit. Still doesn't replicate larger modules, but we're getting there. May require a change in PouchDB core so we don't have to read all the doc's attachments into memory at once.

garrensmith · 2017-02-16T16:04:38Z

Three things left to do:

Tests must pass on Travis
Update readme's
Update package.json
Create release scripts

nolanlawson · 2017-02-16T17:23:58Z

We also need to put pouchdb-server package into packages/node_modules.

The basic idea is that the top-level package.json is a dummy package that never gets published. It just holds the dependencies so that Greenkeeper can update them. Then at publish time we scan for dependencies using find-requires and then inject those into the sub-package.jsons.

If I have time I'll work on this but it looks like a 1-2 full days effort at least (judging based on the time I put into the pouchdb monorepo).

garrensmith · 2017-02-17T12:40:20Z

I made some nice progress on this and am almost done. Tests are all passing. I've updated readme's and package.json. Pouchdb-server was actually added to the file structure on my machine as a subpackage but for some reason it wasn't added to the repo.

At this stage I think the only thing that needs to be done is add the release functionality. I'm hoping @nolanlawson can help me with that otherwise I will take a look next week. Once we have done that i would like to merge this and then move the issues and PR's from express.

Also cc @yaronyg and @gr2m to let them know about this since they have both expressed interest in this before.

gr2m · 2017-02-18T00:27:56Z

README.md

-Please make your changes on a separate branch whose name reflects your changes, push them to your fork, and open a pull request!
-
-For commit message style guidelines, please refer to [PouchDB CONTRIBUTING.md](https://github.com/pouchdb/pouchdb/blob/master/CONTRIBUTING.md).
+See the CONTRIBUTING.md file for how to get involved


maybe link the CONTRIBUTING.md file?
[CONTRIBUTING.md](https://github.com/pouchdb/pouchdb-server/blob/master/CONTRIBUTING.md)

nolanlawson · 2017-02-18T16:32:50Z

OK, I have cleaned up the structure a little bit, implemented a release script, and tested it on Sinopia to make sure everything is working correctly. Release instructions are now in CONTRIBUTING.md.

Once this is green, I will merge and release 2.3.0 for both packages so we can get this in fast. (Note that we don't need to release 3.0.0 because there are no breaking changes here.)

garrensmith · 2017-02-18T16:56:11Z

Awesome. Thanks for taking it over the finish line.

nolanlawson · 2017-02-18T16:57:59Z

No prob. Last bit is just getting the README cleaned up. I'll do that before publishing.

nolanlawson · 2017-02-18T17:35:43Z

Done. 2.3.0 are published for both express-pouchdb and pouchdb-server. Thanks everyone!

gr2m · 2017-02-18T17:37:33Z

great work @garrensmith @nolanlawson 🎉

nolanlawson · 2017-02-18T19:52:29Z

Had a few publishing snafus, but 2.3.3 should be good now. Fourth time's the charm. 😅

garrensmith · 2017-02-19T04:09:49Z

Woohoo. Thanks Nolan

nolanlawson and others added 30 commits May 27, 2014 21:50

(#39) - implement replication history

0d59572

(#41) - return correct error code in changes

040fb76

0.2.0

763c1f7

(#46) - make uuids more random

f68853b

(#38) - in-memory/filepath option

a1f83db

Also related to #36. Also fixes #51 because we now use the pouchdb-all-dbs plugin.

0.3.0

f44246d

(#45) - update fauxton

4229b67

Built from https://github.com/apache/couchdb-fauxton Looks and feels a lot nicer now, although many of the sidebar options don't work (e.g. config).

(#55) - stub out _config

d540afc

(#58) - return the right status code

1d1c04e

(#14) - adds rewrites support

8a76524

(#62) - remove useless logging

66b6f76

(#65) - Adds list, show & update function support.

5644e5e

(#66) - stub out _log, _stats

baf799f

(#59) - Update Fauxton with new branding

222e734

Also update README to note Fauxton branding and PouchDB.defaults API.

0.3.1

61006dc

(#69) - Adds validate_doc_update function support

987a989

(#71) - Some improvements (couchdb-harness progress)

c64ec6f

0.4.0

0170fe7

(#73) - Test in travis with pouchdb-server

5c0634b

(#72) - add verifyinstall

2d5cc2e

0.5.0

f4b7afe

(pouchdb/pouchdb#2537) - lock express to 4.6.1

f7071a0

0.5.1

395154b

(#78) - clearer contributing guidelines

2ee456b

(#81) - fixes for npm-fullfat-registry

ecde3fb

Notable additions: * startTime in db.info() * multipart/related support for PUT * changes with feed=continuous actually does a continuous feed like it's supposed to

0.5.2

87db1f4

(pouchdb/pouchdb#2546) - better error handling

487d01a

0.5.3

086d61c

(#85) - only use rawBodyParser where necessary

37277f1

Also clean up the multiparty usage a bit. Still doesn't replicate larger modules, but we're getting there. May require a change in PouchDB core so we don't have to read all the doc's attachments into memory at once.

0.5.4

0ff7264

garrensmith and others added 3 commits February 16, 2017 18:10

remove empty command

cc80fd2

fix eslint

c83b503

add mapreduce tests

f1151dc

garrensmith added 11 commits February 17, 2017 09:53

fixing tests

ddf169b

use latest pouchdb version

73f52fa

add pouchdb-server

7e8b5da

travis debug

1ecb911

logging on test script

20af30e

more logging

12ab2c1

travis again

039e4a8

more

3fc5556

remove pouchdb-tests directory

a2f6e66

link express-pouchdb and update readmes

ec09f05

set pre-release version

db3796b

gr2m reviewed Feb 18, 2017

View reviewed changes

cleanup structure, implement release script

753d7fc

nolanlawson added 2 commits February 18, 2017 08:59

fix bin file

600b3f3

update READMEs, CONTRIBUTING, and package.jsons

8b7b73d

nolanlawson merged commit 8b7b73d into master Feb 18, 2017

nolanlawson mentioned this pull request Feb 18, 2017

RFC: Combine Pouchdb-server and express-pouchdb #150

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mono repo take three #168

Mono repo take three #168

garrensmith commented Feb 16, 2017

garrensmith commented Feb 16, 2017

nolanlawson commented Feb 16, 2017 •

edited

Loading

garrensmith commented Feb 17, 2017

gr2m Feb 18, 2017 •

edited

Loading

nolanlawson Feb 18, 2017

nolanlawson commented Feb 18, 2017

garrensmith commented Feb 18, 2017 via email •

edited by nolanlawson

Loading

nolanlawson commented Feb 18, 2017

nolanlawson commented Feb 18, 2017

gr2m commented Feb 18, 2017

nolanlawson commented Feb 18, 2017

garrensmith commented Feb 19, 2017 via email •

edited by gr2m

Loading

Mono repo take three #168

Mono repo take three #168

Conversation

garrensmith commented Feb 16, 2017

garrensmith commented Feb 16, 2017

nolanlawson commented Feb 16, 2017 • edited Loading

garrensmith commented Feb 17, 2017

gr2m Feb 18, 2017 • edited Loading

Choose a reason for hiding this comment

nolanlawson Feb 18, 2017

Choose a reason for hiding this comment

nolanlawson commented Feb 18, 2017

garrensmith commented Feb 18, 2017 via email • edited by nolanlawson Loading

nolanlawson commented Feb 18, 2017

nolanlawson commented Feb 18, 2017

gr2m commented Feb 18, 2017

nolanlawson commented Feb 18, 2017

garrensmith commented Feb 19, 2017 via email • edited by gr2m Loading

nolanlawson commented Feb 16, 2017 •

edited

Loading

gr2m Feb 18, 2017 •

edited

Loading

garrensmith commented Feb 18, 2017 via email •

edited by nolanlawson

Loading

garrensmith commented Feb 19, 2017 via email •

edited by gr2m

Loading