New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono repo take three #168

Merged
merged 300 commits into from Feb 18, 2017

Conversation

Projects
None yet
@garrensmith
Copy link
Member

garrensmith commented Feb 16, 2017

This is my third and final push on getting this mono-repo. I've imported express-server in with full git history.

nolanlawson and others added some commits May 24, 2014

(#38) - in-memory/filepath option
Also related to #36.
Also fixes #51 because we now use the pouchdb-all-dbs
plugin.
(#45) - update fauxton
Built from https://github.com/apache/couchdb-fauxton
Looks and feels a lot nicer now, although many
of the sidebar options don't work (e.g. config).
(#59) - Update Fauxton with new branding
Also update README to note Fauxton branding and PouchDB.defaults API.
(#81) - fixes for npm-fullfat-registry
Notable additions:

* startTime in db.info()
* multipart/related support for PUT
* changes with feed=continuous actually does
  a continuous feed like it's supposed to
(#85) - only use rawBodyParser where necessary
Also clean up the multiparty usage a bit.
Still doesn't replicate larger modules, but we're
getting there. May require a change in PouchDB
core so we don't have to read all the doc's attachments
into memory at once.
@garrensmith

This comment has been minimized.

Copy link
Member

garrensmith commented Feb 16, 2017

Three things left to do:

  • Tests must pass on Travis
  • Update readme's
  • Update package.json
  • Create release scripts

garrensmith and others added some commits Feb 16, 2017

@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Feb 16, 2017

We also need to put pouchdb-server package into packages/node_modules.

The basic idea is that the top-level package.json is a dummy package that never gets published. It just holds the dependencies so that Greenkeeper can update them. Then at publish time we scan for dependencies using find-requires and then inject those into the sub-package.jsons.

If I have time I'll work on this but it looks like a 1-2 full days effort at least (judging based on the time I put into the pouchdb monorepo).

garrensmith added some commits Feb 17, 2017

@garrensmith

This comment has been minimized.

Copy link
Member

garrensmith commented Feb 17, 2017

I made some nice progress on this and am almost done. Tests are all passing. I've updated readme's and package.json. Pouchdb-server was actually added to the file structure on my machine as a subpackage but for some reason it wasn't added to the repo.

At this stage I think the only thing that needs to be done is add the release functionality. I'm hoping @nolanlawson can help me with that otherwise I will take a look next week. Once we have done that i would like to merge this and then move the issues and PR's from express.

Also cc @yaronyg and @gr2m to let them know about this since they have both expressed interest in this before.

README.md Outdated
Please make your changes on a separate branch whose name reflects your changes, push them to your fork, and open a pull request!

For commit message style guidelines, please refer to [PouchDB CONTRIBUTING.md](https://github.com/pouchdb/pouchdb/blob/master/CONTRIBUTING.md).
See the CONTRIBUTING.md file for how to get involved

This comment has been minimized.

@gr2m

gr2m Feb 18, 2017

Contributor

maybe link the CONTRIBUTING.md file?
[CONTRIBUTING.md](https://github.com/pouchdb/pouchdb-server/blob/master/CONTRIBUTING.md)

This comment has been minimized.

@nolanlawson
@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Feb 18, 2017

OK, I have cleaned up the structure a little bit, implemented a release script, and tested it on Sinopia to make sure everything is working correctly. Release instructions are now in CONTRIBUTING.md.

Once this is green, I will merge and release 2.3.0 for both packages so we can get this in fast. (Note that we don't need to release 3.0.0 because there are no breaking changes here.)

@garrensmith

This comment has been minimized.

Copy link
Member

garrensmith commented Feb 18, 2017

@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Feb 18, 2017

No prob. Last bit is just getting the README cleaned up. I'll do that before publishing.

nolanlawson added some commits Feb 18, 2017

@nolanlawson nolanlawson merged commit 8b7b73d into master Feb 18, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Feb 18, 2017

Done. 2.3.0 are published for both express-pouchdb and pouchdb-server. Thanks everyone!

@gr2m

This comment has been minimized.

Copy link
Contributor

gr2m commented Feb 18, 2017

great work @garrensmith @nolanlawson 🎉

@nolanlawson

This comment has been minimized.

Copy link
Member

nolanlawson commented Feb 18, 2017

Had a few publishing snafus, but 2.3.3 should be good now. Fourth time's the charm. 😅

@garrensmith

This comment has been minimized.

Copy link
Member

garrensmith commented Feb 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment