Pouchdb replicator #209

garrensmith · 2017-02-20T19:44:09Z

This adds in the pouchdb-replicator plugin with full git history.

/cc @marten-de-vries

… much untested). Also validation update (will become 1.1.0).

… some improvements to coroutines (nesting them, most notably)

…rotections for them like in CouchDB). No regressions, but JS test coverage isn't complete yet.

http://greenkeeper.io/

https://greenkeeper.io/

…3008300ce1dd58e9ff5a6c21322db548' git-subtree-dir: packages/node_modules/pouchdb-replicator git-subtree-mainline: 66fc789 git-subtree-split: 4008445

nolanlawson · 2017-02-20T19:58:02Z

packages/node_modules/express-pouchdb/package.json

+    "sanitize-filename": "^1.6.1",
+    "uuid": "^3.0.1",
+    "pouchdb-fauxton": "^0.0.5"
+  },


@garrensmith you actually don't need to add any dependencies in the sub-packages; just keep it empty. They'll automatically be filled in by release.sh.

nolanlawson · 2017-02-20T19:58:26Z

packages/node_modules/pouchdb-replicator/.travis.yml

+
+#after_success:
+#  - npm run helper -- semantic-release
+


we can remove this file assuming the top-level .travis.yml also runs the tests

nolanlawson · 2017-02-20T19:59:37Z

packages/node_modules/pouchdb-replicator/package.json

@@ -0,0 +1,35 @@
+{
+  "name": "pouchdb-replicator",
+  "version": "2.3.4",


this doesn't need to include a version; that's automatically added at release time.

OTOH we have to make sure we can actually publish a new version that's the same verison as express-pouchdb/pouchdb-server. Since the latest pouchdb-replicator is 2.1.3 looks like we're good.

nolanlawson · 2017-02-20T20:01:14Z

tests/mocha.opts

@@ -1,2 +1,3 @@
 --colors
+--compilers js:pouchdb-plugin-helper/mocha-babel 


I would much prefer to keep things simple and not have any ES6+ in the codebase, but if that's how pouchdb-replicator and the other plugins are written, then we should probably have a unified strategy for what we're doing with transpilation. It seems ES6+ is currently only used in the tests, not the source code?

Alternatively I would be okay with just converting from ES modules to CommonJS and using only Node 4+ features. We only support Node 4+ anyhow. Then we could get rid of the mocha-babel helper entirely.

The tests were originally written in Python. I ported them to ES6 since it allowed for the most direct translation. They depend quite heavily on async/await, which as far as I know is not supported even in node 4+.

nolanlawson

Also we seem to be missing a LICENSE file?

nolanlawson · 2017-02-20T20:04:01Z

packages/node_modules/pouchdb-replicator/package.json

+  "devDependencies": {
+    "pouchdb-plugin-helper": "^3.0.0"
+  },
+  "optionalDependencies": {}


We seem to be missing a LICENSE file for pouchdb-replicator and also "license": "Apache-2.0" in the package.json.

Hmm, probably forgot that while moving to Github. Anyway, I always meant for this to be under Apache-2.0; re-licensing it under ISC or MIT license is fine with me too.

nolanlawson · 2017-02-20T20:04:57Z

Thanks for putting the work in @garrensmith ! Just a few changes and it should be good to go. Also I added you as a publisher: https://www.npmjs.com/package/pouchdb-replicator

garrensmith · 2017-02-20T20:07:19Z

Thanks Nolan. One thing. What do we do about licensing. Pouchdb-replicator is licensed under Apache. Everything else is MIT. Is that ok?

nolanlawson · 2017-02-20T20:13:41Z

Ask Marten if he's okay switching to Apache

…

----- Nolan Lawson http://nolanlawson.com https://github.com/nolanlawson

On Feb 20, 2017 12:07 PM, "garren smith" ***@***.***> wrote: Thanks Nolan. One thing. What do we do about licensing. Pouchdb-replicator is licensed under Apache. Everything else is MIT. Is that ok? All misspelling thanks to my iPhone. On Mon, Feb 20, 2017 at 10:04 PM +0200, "Nolan Lawson" < ***@***.***> wrote: Thanks for putting the work in @garrensmith ! Just a few changes and it should be good to go. Also I added you as a contributor: https://www.npmjs.com/package/pouchdb-replicator — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#209 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARUwiKAdwB3DI0LGHmSj3ShPJjMmZpFks5refJ4gaJpZM4MGjj9> .

marten-de-vries · 2017-02-20T20:33:05Z

Just commented inline:

Hmm, probably forgot that while moving to Github. Anyway, I always meant for this to be under Apache-2.0; re-licensing it under ISC or MIT license is fine with me too.

So feel free to do whatever is most practical/most in line with other packages. And nice to see all the monorepo work lately!

garrensmith · 2017-02-21T12:22:32Z

I've converted all the tests to es2015. It took pretty long but I think its at least more consistent.
I've also made the other fixes.

gr2m · 2017-02-21T18:32:53Z

awwman thanks for doing the hard work <3

nolanlawson · 2017-02-22T01:23:38Z

@garrensmith looks like we still have dependencies/version in the sub-packages and a dangling .travis.yml file? Other than that I'm 👍, LGTM!

(BTW you can run node ,.bin/prerelease.js to see exactly what happens during the release process; I use this to debug to make sure that the dependencies/version are correctly set right before publish.)

garrensmith · 2017-02-22T14:36:58Z

Thanks I've cleaned it up. The dependencies / versions keeps appearing because I run the bin/prerelease to make sure I have everything setup correctly. If the tests pass I'm going to merge.

nolanlawson

👍 awesome

marten-de-vries · 2017-02-22T19:10:36Z

Very nice to see a monorepo taking shape for pouchdb-server as well!

This reverts commit b824fbd.

nolanlawson · 2017-02-24T02:05:21Z

I fixed the mistake I made when I originally merged this, which was that I squash-rebased everything and thus @marten-de-vries didn't get any credit for pouchdb-replicator. That's fixed now; I reverted b824fbd and merged in the pouchdb-replicator branch the traditional way, so the full history is preserved. Thank you @garrensmith for alerting me to my mistake!

marten-de-vries and others added 19 commits June 30, 2014 20:54

PouchDB plugin updates. (new replicator plug-in initial code - pretty…

8fb99eb

… much untested). Also validation update (will become 1.1.0).

A bunch of JS improvements (incl. replicator module (experimental)) &…

3a54f47

… some improvements to coroutines (nesting them, most notably)

Improved docs + JS

117b3b8

Improvements to replicator + auth; documentation translations

0fccb76

Smaller JS modules.

7f4a1fe

Makes _users and _replicator databases system databases (sets extra p…

d3ca1cb

…rotections for them like in CouchDB). No regressions, but JS test coverage isn't complete yet.

JS is all at 1.0.0 at least now & published.

ffcdfde

Fixed a bug in pouchdb-wrappers

1f116b8

pouchdb-replicator update.

b2e4085

Improvements to pouchdb-replicator

e43d8f1

Plug-in improvements

5b5f0dc

2.1.2; moved to github

d98aa30

(pouchdb/express-pouchdb#232) - Modernize pouchdb-replicator

875fa64

2.1.3

f4d291f

chore(package): update dependencies

a16766f

http://greenkeeper.io/

chore(package): update pouchdb-plugin-helper to version 3.0.0

8f00b7a

http://greenkeeper.io/

chore(package): update random-uuid-v4 to version 0.0.6

4008445

https://greenkeeper.io/

Add 'packages/node_modules/pouchdb-replicator/' from commit '40084455…

a23135f

…3008300ce1dd58e9ff5a6c21322db548' git-subtree-dir: packages/node_modules/pouchdb-replicator git-subtree-mainline: 66fc789 git-subtree-split: 4008445

add pouchdb-replicator to the repo

18bff78

garrensmith mentioned this pull request Feb 20, 2017

Finish monorepo merge #197

Closed

12 tasks

nolanlawson requested changes Feb 20, 2017

View reviewed changes

convert tests to es2015

1543a57

garrensmith force-pushed the pouchdb-replicator branch from f502372 to 1543a57 Compare February 21, 2017 12:21

remove packages

f554e0f

nolanlawson approved these changes Feb 22, 2017

View reviewed changes

nolanlawson merged commit b824fbd into master Feb 22, 2017

nolanlawson added a commit that referenced this pull request Feb 24, 2017

Revert "(#209) - add pouchdb-replicator"

adf52c2

This reverts commit b824fbd.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pouchdb replicator #209

Pouchdb replicator #209

garrensmith commented Feb 20, 2017

nolanlawson Feb 20, 2017

nolanlawson Feb 20, 2017 •

edited

Loading

nolanlawson Feb 20, 2017

nolanlawson Feb 20, 2017

nolanlawson Feb 20, 2017

marten-de-vries Feb 20, 2017

nolanlawson left a comment

nolanlawson Feb 20, 2017

marten-de-vries Feb 20, 2017 •

edited

Loading

nolanlawson commented Feb 20, 2017 •

edited

Loading

garrensmith commented Feb 20, 2017 via email •

edited by gr2m

Loading

nolanlawson commented Feb 20, 2017 via email

marten-de-vries commented Feb 20, 2017

garrensmith commented Feb 21, 2017

gr2m commented Feb 21, 2017

nolanlawson commented Feb 22, 2017

garrensmith commented Feb 22, 2017

nolanlawson left a comment

marten-de-vries commented Feb 22, 2017

nolanlawson commented Feb 24, 2017

		@@ -1,2 +1,3 @@
		--colors
		--compilers js:pouchdb-plugin-helper/mocha-babel

Pouchdb replicator #209

Pouchdb replicator #209

Conversation

garrensmith commented Feb 20, 2017

nolanlawson Feb 20, 2017

Choose a reason for hiding this comment

nolanlawson Feb 20, 2017 • edited Loading

Choose a reason for hiding this comment

nolanlawson Feb 20, 2017

Choose a reason for hiding this comment

nolanlawson Feb 20, 2017

Choose a reason for hiding this comment

nolanlawson Feb 20, 2017

Choose a reason for hiding this comment

marten-de-vries Feb 20, 2017

Choose a reason for hiding this comment

nolanlawson left a comment

Choose a reason for hiding this comment

nolanlawson Feb 20, 2017

Choose a reason for hiding this comment

marten-de-vries Feb 20, 2017 • edited Loading

Choose a reason for hiding this comment

nolanlawson commented Feb 20, 2017 • edited Loading

garrensmith commented Feb 20, 2017 via email • edited by gr2m Loading

nolanlawson commented Feb 20, 2017 via email

marten-de-vries commented Feb 20, 2017

garrensmith commented Feb 21, 2017

gr2m commented Feb 21, 2017

nolanlawson commented Feb 22, 2017

garrensmith commented Feb 22, 2017

nolanlawson left a comment

Choose a reason for hiding this comment

marten-de-vries commented Feb 22, 2017

nolanlawson commented Feb 24, 2017

nolanlawson Feb 20, 2017 •

edited

Loading

marten-de-vries Feb 20, 2017 •

edited

Loading

nolanlawson commented Feb 20, 2017 •

edited

Loading

garrensmith commented Feb 20, 2017 via email •

edited by gr2m

Loading