finish up monorepo

[gr2m]

finishes merging currently listed repos at #197

I think the separate pull requests run into issues because of cross references, so I try to solve them all at once here :)

closes #242, closes #244, closes #245, closes #248

[gr2m]

I can now reproduce the error with npm run test-express-minimum when testing in node 6.11.0 & npm 3.10.10.

The error here: https://travis-ci.org/pouchdb/pouchdb-server/jobs/250086626#L3465 comes from this assertion here: https://github.com/pouchdb/pouchdb/blob/master/tests/integration/test.all_docs.js#L752

when run with npm run test-express-minimum, then _conflicts is an empty array [] instead of undefined. So that might be a pouchdb server error somewhere. But all the rest is passing, so I think this is good to go

[gr2m]

I’m positive that this is fixed in latest PouchDB 6. But upgrading to it (and testing with latest PouchDB test suite) is another rabbit hole :(

I honestly don’t know what to do. I say we merge this in despite the failing tests. We continue to add all of the other modules that pouchdb-server depends on and merge it into the repo. Then we upgrade to latest POuchDB and fix all the incompatibilities, now that they are all in the mono repo.

I fear this is another 1-3 days of work, depending on how many other rabbit holes there are.

[gr2m]

These are the tests that are currently failing from the PouchDB Test suite at https://github.com/pouchdb/pouchdb/tree/f9beadd (which i think is the last commit before 6.2.0 release)

diff --git a/tests/integration/test.bulk_docs.js b/tests/integration/test.bulk_docs.js
index c34cb47..12227a3 100644
--- a/tests/integration/test.bulk_docs.js
+++ b/tests/integration/test.bulk_docs.js
@@ -370,7 +370,7 @@ adapters.forEach(function (adapter) {
       });
     });
 
-    it('#2935 new_edits=false with single unauthorized', function (done) {
+    it.skip('#2935 new_edits=false with single unauthorized', function (done) {
 
       testUtils.isCouchDB(function (isCouchDB) {
         if (adapter !== 'http' || !isCouchDB) {
diff --git a/tests/integration/test.replication.js b/tests/integration/test.replication.js
index 7d20336..9a69341 100644
--- a/tests/integration/test.replication.js
+++ b/tests/integration/test.replication.js
@@ -3274,7 +3274,7 @@ adapters.forEach(function (adapters) {
     // test validate_doc_update, which is a reasonable substitute
     // for testing design doc replication of non-admin users, since we
     // always test in admin party
-    it('#2268 dont stop replication if single forbidden', function (done) {
+    it.skip('#2268 dont stop replication if single forbidden', function (done) {
 
       testUtils.isCouchDB(function (isCouchDB) {
         if (adapters[1] !== 'http' || !isCouchDB) {
@@ -3315,7 +3315,7 @@ adapters.forEach(function (adapters) {
       });
     });
 
-    it('#2268 dont stop replication if single unauth', function (done) {
+    it.skip('#2268 dont stop replication if single unauth', function (done) {
 
       testUtils.isCouchDB(function (isCouchDB) {
         if (adapters[1] !== 'http' || !isCouchDB) {
@@ -3356,7 +3356,7 @@ adapters.forEach(function (adapters) {
       });
     });
 
-    it('#2268 dont stop replication if many unauth', function (done) {
+    it.skip('#2268 dont stop replication if many unauth', function (done) {
 
       testUtils.isCouchDB(function (isCouchDB) {
         if (adapters[1] !== 'http' || !isCouchDB) {
@@ -3400,7 +3400,7 @@ adapters.forEach(function (adapters) {
 
     // Errors from validate_doc_update should have the message
     // defined in PourchDB.Errors instead of the thrown value.
-    it('#3171 Forbidden validate_doc_update error message',
+    it.skip('#3171 Forbidden validate_doc_update error message',
         function (done) {
       testUtils.isCouchDB(function (isCouchDB) {
         if (adapters[1] !== 'http' || !isCouchDB) {
@@ -3463,7 +3463,7 @@ adapters.forEach(function (adapters) {
       replicationHandler.cancel();
     });
 
-    it('#3171 Unauthorized validate_doc_update error message',
+    it.skip('#3171 Unauthorized validate_doc_update error message',
         function (done) {
       testUtils.isCouchDB(function (isCouchDB) {
         if (adapters[1] !== 'http' || !isCouchDB) {
@@ -3510,7 +3510,7 @@ adapters.forEach(function (adapters) {
       });
     });
 
-    it('#3070 Doc IDs with validate_doc_update errors',
+    it.skip('#3070 Doc IDs with validate_doc_update errors',
         function (done) {
       testUtils.isCouchDB(function (isCouchDB) {
         if (adapters[1] !== 'http' || !isCouchDB) {
@@ -3560,7 +3560,7 @@ adapters.forEach(function (adapters) {
       });
     });
 
-    it('#3270 triggers "denied" events', function (done) {
+    it.skip('#3270 triggers "denied" events', function (done) {
       testUtils.isCouchDB(function (isCouchDB) {
         if (/*adapters[1] !== 'http' || */!isCouchDB) {
           return done();
diff --git a/tests/integration/test.sync.js b/tests/integration/test.sync.js
index dacf092..f79c220 100644
--- a/tests/integration/test.sync.js
+++ b/tests/integration/test.sync.js
@@ -611,7 +611,7 @@ adapters.forEach(function (adapters) {
       }, done);
     });
 
-    it('#3270 triggers "denied" events',
+    it.skip('#3270 triggers "denied" events',
         function (done) {
       testUtils.isCouchDB(function (isCouchDB) {
         if (/*adapters[1] !== 'http' || */!isCouchDB) {
@@ -657,7 +657,7 @@ adapters.forEach(function (adapters) {
       });
     });
 
-    it('#3270 triggers "denied" events, reverse direction',
+    it.skip('#3270 triggers "denied" events, reverse direction',
       function (done) {
         testUtils.isCouchDB(function (isCouchDB) {
           if (/*adapters[1] !== 'http' || */!isCouchDB) {

[garrensmith]

You can change the pouchdb test version used herer https://github.com/pouchdb/pouchdb-server/blob/master/bin/test-setup.sh#L18

But if you still struggling I guess lets merge and take it from there.

[marten-de-vries]

@loic: is this PR still useful as a base to get pouchdb-vhost, pouchdb-size and pouchdb-show merged after all the work you've done recently? Or can it be closed?

[loic]

I'm using it as inspiration but it doesn't need to remain open as I'm gonna open new ones.

[marten-de-vries]

Ok, then I'll close this PR and the ones it's based on.