New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#6143) - perf tests: use marky, measure median, add iterations param #6143

Merged

daleharvey merged 1 commit into master from median

Jan 18, 2017

Member

nolanlawson commented Jan 16, 2017

A few changes I find make our perf tests more trustworthy/usable:

use marky to simplify performance mark/measure usage
report the median of n iterations rather than just the total
allow user to pass in ?iterations=n or ITERATIONS=n to change default iterations

This will break any dashboard tool that might be written with our current output, but I'm not sure if anyone has created one or is using it.


          (#6143) - perf tests: use marky, measure median, add iterations param

b3e8f60

daleharvey approved these changes

View reviewed changes

Member

daleharvey commented Jan 18, 2017

Look like some nice changes, thanks

daleharvey merged commit dadbbef into master

nolanlawson mentioned this pull request

Release 6.1.2 #6208

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment