(#6167) - fix and improve test scripts #6167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to do some simple performance tests:
And I found that basic stuff was not working. So I fixed several issues with our test scripts, notably:
results.completed
being called too early (end of test suite, not end of all test suites)memory
in NodeGREP
not working correctly with markingresults.completed
Our test scripts could probably use a heck of a lot more refactoring, but for the time being they're at least usable now.