Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#6167) - fix and improve test scripts #6167

Merged
merged 1 commit into from Jan 25, 2017
Merged

Conversation

nolanlawson
Copy link
Member

I was trying to do some simple performance tests:

PERF=1 CLIENT=selenium:chrome GREP=temp-views ITERATIONS=5 npm t

And I found that basic stuff was not working. So I fixed several issues with our test scripts, notably:

  • results.completed being called too early (end of test suite, not end of all test suites)
  • not able to test memory in Node
  • GREP not working correctly with marking results.completed
  • not able to specify number of iterations
  • object printed to console too large, too hard to read

Our test scripts could probably use a heck of a lot more refactoring, but for the time being they're at least usable now.

@nolanlawson nolanlawson changed the title (#6166) - fix and improve test scripts (#6167) - fix and improve test scripts Jan 23, 2017
@nolanlawson nolanlawson merged commit 7089d39 into master Jan 25, 2017
@nolanlawson nolanlawson mentioned this pull request Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants