Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pouchdb-http: unmaintained #8014

Closed
ronag opened this issue Feb 22, 2020 · 10 comments
Closed

pouchdb-http: unmaintained #8014

ronag opened this issue Feb 22, 2020 · 10 comments

Comments

@ronag
Copy link
Contributor

ronag commented Feb 22, 2020

When running i live changes feed using the http adaptor there seem to be a memory leak here, https://github.com/pouchdb/pouchdb/blob/master/packages/node_modules/pouchdb-adapter-http/src/index.js#L1009

Looks like the http adapter will default to return_docs: true even when running in "live" mode which means that it will eventually run out of memory.

@ronag
Copy link
Contributor Author

ronag commented Feb 22, 2020

db
  .changes({
    since: seq || 'now',
    live: true
  })
  .on('change', change => o.next(change))
  .on('error', err => o.error(err))

@ronag
Copy link
Contributor Author

ronag commented Feb 22, 2020

The problem is we are using pouchdb-http which is no longer maintained... this problem is fixed in PouchDB 7.

That's going to be a problem going forwards...

@ronag ronag changed the title http: changes memory leak pouchdb-http: unmaintained Feb 22, 2020
@seigel
Copy link
Contributor

seigel commented Feb 28, 2020

Ideas on fixes? Is the path going forward replacing pouchdb-http with something else or find a maintainer of pouchdb-http?

@ronag
Copy link
Contributor Author

ronag commented Feb 28, 2020

Is it possible to add a deprecation warning to the package?

@AGrzes
Copy link

AGrzes commented Mar 7, 2020

pouchdb-http contains 2 lines of code

module.exports = require('pouchdb-core')
  .plugin(require('pouchdb-adapter-http'))

and 2 dependecnies

    "pouchdb-adapter-http": "^6.0.3",
    "pouchdb-core": "^6.0.3"

so reproducing those 2 lines of code inside Your project but using PouchDB 7 would be a solution.

Essentially follow instructions on this page.

@ronag
Copy link
Contributor Author

ronag commented Mar 7, 2020

@AGrzes: Yes, we don't use this package anymore. However, other people might be using it, thinking they have the latest version of pouch not knowing this package is no longer maintained.

We were very surprised why we were seeing old bugs until we realized that this package wasn't on pouch 7.x.

@AGrzes
Copy link

AGrzes commented Mar 7, 2020

@ronag You are right - and I believe @nolanlawson is both maintainer of the package github repository and collaborator on the npm package so can we please get deprecation warning

@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 6, 2020
@NotMoni
Copy link
Contributor

NotMoni commented May 6, 2020

You can’t close a issue that’s a problem

@stale stale bot removed the wontfix label May 6, 2020
@stale
Copy link

stale bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 5, 2020
@stale stale bot closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants