Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Docs) markdown regression due to typography overhaul #5359

Closed
nolanlawson opened this issue Jun 16, 2016 · 3 comments
Closed

(Docs) markdown regression due to typography overhaul #5359

nolanlawson opened this issue Jun 16, 2016 · 3 comments

Comments

@nolanlawson
Copy link
Member

As noted on Twitter: https://twitter.com/optikfluffel/status/743462052849680384

It appears that anywhere we include an alert block, the markdown gets lost immediately afterwards. Since I didn't have time to look into this, I just reverted fdbaaf0. in a branch and did npm run publish-site as a hotfix. It's still broken in master.

/cc @NickColley Sorry for not noticing this during the PR

@nolanlawson
Copy link
Member Author

You can see this on both the custom.html page and the adapters.html page (it's particularly bad there).

@NickColley
Copy link
Contributor

NickColley commented Jun 16, 2016

Normally I've found this happens when there's whitespace issues. E.g. making sure there's no indentation and markup is on one line normally fixes these kinds of things.

Will try and sort this soon if someone else doesn't suss it out

@daleharvey
Copy link
Member

Fixed in 1c4475f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants