Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

total_rows is not consistent between worker threads and main thread #6055

Closed
nolanlawson opened this issue Dec 22, 2016 · 2 comments
Closed

total_rows is not consistent between worker threads and main thread #6055

nolanlawson opened this issue Dec 22, 2016 · 2 comments
Assignees
@nolanlawson
Labels
bug Confirmed bug

Comments

@nolanlawson
Copy link
Member

There's an in-memory cache for total_rows (aka doc_count) in the IDB adapter. This is cute and has some perf benefits, but it also introduces inconsistencies between the worker thread and main thread because we're caching stuff in-memory, outside of the IDB transaction.

Given the increasing usage of web workers and service workers, I don't think this is a safe tradeoff to make anymore. We should just remove this optimization and look for other, safer optimizations.
@nolanlawson nolanlawson added the bug Confirmed bug label Dec 22, 2016
@nolanlawson
Copy link
Member Author

Technically you can also reproduce this by just using the same PouchDB in multiple tabs, so it's not safe for that case either.

nolanlawson added a commit that referenced this issue Dec 22, 2016
@nolanlawson
(#6055) - remove docCount optimization from IDB
47b4576
nolanlawson added a commit that referenced this issue Dec 22, 2016
@nolanlawson
(#6055) - remove docCount optimization from IDB
2baa95c
nolanlawson added a commit that referenced this issue Dec 22, 2016
@nolanlawson
(#6055) - remove docCount optimization from WebSQL
ce8b097
nolanlawson added a commit that referenced this issue Dec 22, 2016
@nolanlawson
(#6055) - remove docCount optimization from IDB
a4e1237
nolanlawson added a commit that referenced this issue Dec 22, 2016
@nolanlawson
(#6055) - remove docCount optimization from WebSQL
5d86f1f
nolanlawson added a commit that referenced this issue Dec 23, 2016
@nolanlawson
(#6055) - remove docCount optimization from IDB
0ea6baa 
Removes this unsafe optimization.
nolanlawson added a commit that referenced this issue Dec 23, 2016
@nolanlawson
(#6055) - remove docCount optimization from WebSQL
3352d0f 
Removes this unsafe optimization.
@nolanlawson nolanlawson self-assigned this Dec 23, 2016
nolanlawson added a commit that referenced this issue Dec 23, 2016
@nolanlawson
(#6055) - remove docCount optimization from IDB
1c0ddfc 
Removes this unsafe optimization.
@nolanlawson nolanlawson mentioned this issue Dec 24, 2016
Closed
nolanlawson added a commit that referenced this issue Dec 24, 2016
@nolanlawson
(#6055) - remove docCount optimization from IDB
b2f8811 
Removes this unsafe optimization.
daleharvey pushed a commit that referenced this issue Dec 26, 2016
@nolanlawson @daleharvey
(#6055) - remove docCount optimization from IDB
fa2b3a6 
Removes this unsafe optimization.
daleharvey pushed a commit that referenced this issue Dec 26, 2016
@nolanlawson @daleharvey
(#6055) - remove docCount optimization from WebSQL
70750f9 
Removes this unsafe optimization.
@nolanlawson
Copy link
Member Author

Fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nolanlawson nolanlawson

Labels
bug Confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nolanlawson