Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature req colored icons #14

Closed
tablatronix opened this issue Feb 16, 2018 · 4 comments
Closed

Feature req colored icons #14

tablatronix opened this issue Feb 16, 2018 · 4 comments

Comments

@tablatronix
Copy link

tablatronix commented Feb 16, 2018

It would be nice if the circle dots were colored to base or custom color[n] , fallback to a theme_color attribute etc.

Like how git gutter looks

@tablatronix
Copy link
Author

tablatronix commented Feb 16, 2018

			],
			"color" : {
				"base"  : "#70991f", // info message
				"link"  : "#b36915", // link in info message
				"quote" : "#428a99"  // quote in info message
				"icon"  : "#F6F6F6"  // icon (non image) in info message
			},
			"icon"  : "circle"    // remove "icon" not to use icon, "dot", "circle" "bookmark" are possible
		}
	"theme_color": {
		"icons"      : "#FFFFFF",

@poucotm
Copy link
Owner

poucotm commented Feb 17, 2018

You can customize icons as you want by overriding package. Make the folder Packages/Log Highlight/icons, put your icons and change icon settings like - foor/bar.png.
I think it will be better.

@tablatronix
Copy link
Author

I think gitgutter uses white icons, and somehow colorizes them, this lets them be themed.
Not exactly sure how it works, I will dig deeper.

@poucotm
Copy link
Owner

poucotm commented Feb 18, 2018

I've added that in v1.8.7.

@poucotm poucotm closed this as completed Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants