Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add c flag #87

Merged
merged 3 commits into from
May 21, 2023
Merged

Conversation

ravsii
Copy link
Contributor

@ravsii ravsii commented May 21, 2023

Describe your changes

Add -c flag

Edge cases:

  1. -c is uint, any negative number will fallback to usage()
  2. -c 0 = default behaviour, no limits
  3. -r 2 -c 3 will quit after exactly 3 probes (probe -> probe -> resolve -> probe -> quit)

Issue ticket number and link

Closes #72

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added tests.
  • I have run make check and there are no failures.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

@ravsii
Copy link
Contributor Author

ravsii commented May 21, 2023

Let me know if I missed any edge-cases

README.md Outdated Show resolved Hide resolved
ravsii and others added 2 commits May 21, 2023 22:28
Co-authored-by: Pouriya Jamshidi <54482226+pouriyajamshidi@users.noreply.github.com>
Copy link
Owner

@pouriyajamshidi pouriyajamshidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your contributions Alex!

@pouriyajamshidi pouriyajamshidi merged commit 22e41c3 into pouriyajamshidi:master May 21, 2023
3 checks passed
@ravsii ravsii deleted the feat/c-flag branch May 21, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add -c flag to stop after n probes
2 participants