Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contrast in references panel #19

Closed
jiayihu opened this issue Sep 24, 2017 · 6 comments
Closed

Color contrast in references panel #19

jiayihu opened this issue Sep 24, 2017 · 6 comments
Assignees
Milestone

Comments

@jiayihu
Copy link

jiayihu commented Sep 24, 2017

When showing the references, the list of filenames are barely readable if not selected.
schermata 2017-09-24 alle 19 43 25

@pouyakary
Copy link
Owner

Thanks a lot for reporting, I'm on it...

@takato1314
Copy link

takato1314 commented Oct 18, 2017

Hello.

First of all. Thanks for creating such a cool theme. I really love the design that you created.

As aforementioned, i also found the same issue for the dark theme. Please refer to the screenshot:
2017-10-19_0-00-39

Also, i will very appreciate too if you can use a darker color for the mouseover color as shown in the screenshot. Currently, it uses greyish-blue but it doesnt seem to be very clear.

@pouyakary
Copy link
Owner

Hello @takato1314, thanks a lot for reporting.

First of all: Did you set the parenthesis and curly brace colors? why are they magenta and blue?

And also thanks a lot for the reporting. I'm very sorry to see this happening. I'll be surely fixing that.

@takato1314
Copy link

takato1314 commented Oct 19, 2017

Hi @pmkary , thx for the prompt reply. FYI, the coloring of the brackets and curly braces are due to a plugin known as 'bracket-pair-colorizer' (https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer).

Below shows the effect after disabling that plugin and all colorizer plugins that i have:
2017-10-19_13-42-14

As you can see, the words in the reference panel are also not clear during normal/ onmouseover.

@pouyakary
Copy link
Owner

@takato1314 ah good Buddha... We have a long history with braces being rendered in green and if you read release notes you'll notice how much of the bug fixes each time is in regards of brace colors. We don't have those colors in the theme and when I looked at your picture I was like "How this could have happened". Thanks a lot for clarifying this

@pouyakary
Copy link
Owner

@jiayihu @takato1314 @moskal91

Thanks a a lot for your collaboration on this issue. The peek view is a million miles to be perfect but I guess this issue is now resolved. I hope you never experience such problems again.

screen shot 2017-10-30 at 3 02 52 pm

@pouyakary pouyakary added this to the 16.0.0 milestone Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants