-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color contrast in references panel #19
Comments
Thanks a lot for reporting, I'm on it... |
Hello @takato1314, thanks a lot for reporting. First of all: Did you set the parenthesis and curly brace colors? why are they magenta and blue? And also thanks a lot for the reporting. I'm very sorry to see this happening. I'll be surely fixing that. |
Hi @pmkary , thx for the prompt reply. FYI, the coloring of the brackets and curly braces are due to a plugin known as 'bracket-pair-colorizer' (https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer). Below shows the effect after disabling that plugin and all colorizer plugins that i have: As you can see, the words in the reference panel are also not clear during normal/ onmouseover. |
@takato1314 ah good Buddha... We have a long history with braces being rendered in green and if you read release notes you'll notice how much of the bug fixes each time is in regards of brace colors. We don't have those colors in the theme and when I looked at your picture I was like "How this could have happened". Thanks a lot for clarifying this |
@jiayihu @takato1314 @moskal91 Thanks a a lot for your collaboration on this issue. The peek view is a million miles to be perfect but I guess this issue is now resolved. I hope you never experience such problems again. |
When showing the references, the list of filenames are barely readable if not selected.
The text was updated successfully, but these errors were encountered: