Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP-Parser 5 support #174

Merged
merged 1 commit into from Jan 8, 2024
Merged

Add PHP-Parser 5 support #174

merged 1 commit into from Jan 8, 2024

Conversation

sidz
Copy link
Collaborator

@sidz sidz commented Jan 8, 2024

This PR adds PHP-Parser 5 support

@exussum12
Copy link
Collaborator

Should it be current version rather than newest version ?

@sidz
Copy link
Collaborator Author

sidz commented Jan 8, 2024

Hey @exussum12.

createForNewestSupportedVersion is an equivalent to previous behavior $factory->create(ParserFactory::PREFER_PHP7) see Upgrade guide: https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md

@exussum12
Copy link
Collaborator

createForHostVersion() was what I was thinking but happy either way

exussum12
exussum12 previously approved these changes Jan 8, 2024
View reviewed changes
@sidz
Copy link
Collaborator Author

sidz commented Jan 8, 2024

Yeah, you are right. Replaced to createForHostVersion

@sidz sidz merged commit ab4058a into master Jan 8, 2024
21 checks passed
@sidz
Copy link
Collaborator Author

sidz commented Jan 8, 2024

Cheers @exussum12

@sidz sidz deleted the add-php-parser-5-support branch January 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exussum12 exussum12 exussum12 approved these changes

@kubawerlos kubawerlos Awaiting requested review from kubawerlos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidz @exussum12