Broadcast/Minor refactoring and optimization #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tonikocjan
commented
Feb 6, 2024
•
tonikocjan
commented
- Fixed compilation warning (error in Swift 6)
- Performed minor code improvements
- Remove observer optimization
tonikocjan
changed the title
borut-t
approved these changes
Feb 6, 2024
| @@ -3,55 +3,68 @@ | |||
| // PovioKit | |||
| // | |||
| // Created by Domagoj Kulundzic on 26/04/2019. | |||
| // Copyright © 2023 Povio Inc. All rights reserved. | |||
| // Copyright © 2024 Povio Inc. All rights reserved. | |||
There was a problem hiding this comment.
@tonikocjan can you prepare a PR updating all headers year?
tonikocjan
commented
Feb 6, 2024
| } | ||
|
|
||
| extension Broadcast { | ||
| class Weak { |
There was a problem hiding this comment.
There is no need for Weak to be generic at all, hence I removed the generic parameter.
borut-t
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.