Add fixed columns to uni-stark #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
force-pushed
the
uni-stark-with-fixed
branch
2 times, most recently
from
7c5c621
to
7be9b38
Compare
Schaeff
force-pushed
the
uni-stark-with-fixed
branch
from
95be45f
to
c281097
Compare
georgwiese
reviewed
Jul 8, 2024
uni-stark/src/prover.rs
Outdated
Comment on lines
228
to
243
| let preprocessed = RowMajorMatrix::new( | ||
| iter::empty() | ||
| .chain(preprocessed_on_quotient_domain.iter().flat_map( | ||
| |preprocessed_on_quotient_domain| { | ||
| preprocessed_on_quotient_domain.vertically_packed_row(i_start) | ||
| }, | ||
| )) | ||
| .chain(preprocessed_on_quotient_domain.iter().flat_map( | ||
| |preprocessed_on_quotient_domain| { | ||
| preprocessed_on_quotient_domain | ||
| .vertically_packed_row(i_start + next_step) | ||
| }, | ||
| )) | ||
| .collect_vec(), | ||
| preprocessed_width, | ||
| ); |
There was a problem hiding this comment.
Suggested change
| let preprocessed = RowMajorMatrix::new( | |
| iter::empty() | |
| .chain(preprocessed_on_quotient_domain.iter().flat_map( | |
| |preprocessed_on_quotient_domain| { | |
| preprocessed_on_quotient_domain.vertically_packed_row(i_start) | |
| }, | |
| )) | |
| .chain(preprocessed_on_quotient_domain.iter().flat_map( | |
| |preprocessed_on_quotient_domain| { | |
| preprocessed_on_quotient_domain | |
| .vertically_packed_row(i_start + next_step) | |
| }, | |
| )) | |
| .collect_vec(), | |
| preprocessed_width, | |
| ); | |
| let preprocessed = RowMajorMatrix::new( | |
| preprocessed_on_quotient_domain | |
| .map(|on_quotient_domain| { | |
| iter::empty() | |
| .chain(on_quotient_domain.vertically_packed_row(i_start)) | |
| .chain(on_quotient_domain.vertically_packed_row(i_start + next_step)) | |
| .collect_vec() | |
| }) | |
| .unwrap_or_default(), | |
| preprocessed_width, | |
| ); |
How about this?
| config: &SC, | ||
| verifying_key: Option<&StarkVerifyingKey<SC>>, | ||
| air: &A, | ||
| challenger: &mut SC::Challenger, |
There was a problem hiding this comment.
I think the challenger should observe the verification key as well!
There was a problem hiding this comment.
good point, I missed that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.