Adding per PR tests.

.github/workflows/pr-tests.yml

@@ -0,0 +1,34 @@
+name: PR tests
+
+on:
+  workflow_dispatch:
+  pull_request:
+  merge_group:
+  push:
+    branches:
+      - main
+
+env:
+  CARGO_TERM_COLOR: always
+
+jobs:
+  build-and-test:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+      with:
+        submodules: recursive
+    - name: Install Rust toolchain 1.74 (with clippy and rustfmt)
+      run: rustup toolchain install 1.74-x86_64-unknown-linux-gnu && rustup component add clippy --toolchain 1.74-x86_64-unknown-linux-gnu && rustup component add rustfmt --toolchain 1.74-x86_64-unknown-linux-gnu
+    - name: Install pil-stark dependency
+      run: sudo apt-get install -y nlohmann-json3-dev libpqxx-dev nasm
+    - name: Format
+      run: cargo fmt --all --check --verbose
+    - name: Lint
+      run: cargo clippy --all --all-targets --all-features --profile pr-tests -- -D warnings
+    - name: Build
+      run: cargo build --all --all-targets --all-features --profile pr-tests
+    - uses: taiki-e/install-action@nextest
+    - name: Run tests
+      run: RUST_LOG=info cargo nextest run --workspace --all-features --all-targets --cargo-profile pr-tests --nocapture

Cargo.toml

@@ -16,3 +16,12 @@ env_logger = "0.10.0"
 
 [build-dependencies]
 num_cpus = "1.16.0"
+
+[profile.pr-tests]
+inherits = "dev"
+opt-level = 3
+debug = "line-tables-only"
+debug-assertions = true
+overflow-checks = true
+panic = 'unwind'
+codegen-units = 256

build.rs

@@ -4,11 +4,20 @@ fn main() {
     // Run make test in the zkevm-prover directory
     let zkevm_prover_dir = Path::new(env!("CARGO_MANIFEST_DIR")).join("externals/zkevm-prover");
 
-    Command::new("make")
+    eprintln!(
+        "Running make test in zkevm-prover directory: {}",
+        zkevm_prover_dir.display()
+    );
+    let make_status = Command::new("make")
         .arg("test")
         .arg("-j")
         .arg(num_cpus::get().to_string())
         .current_dir(&zkevm_prover_dir)
         .status()
         .expect("Failed to run make test in zkevm-prover directory");
+
+    assert!(
+        make_status.success(),
+        "make test failed in zkevm-prover directory"
+    );
 }

src/lib.rs

@@ -152,7 +152,7 @@ pub fn generate_proof(
     log::info!("Compiling C helpers into a shared library...");
     print_and_run(
         Command::new("g++")
-            .args(&[
+            .args([
                 "-std=c++17",
                 "-shared",
                 "-fPIC",
@@ -166,7 +166,7 @@ pub fn generate_proof(
             .arg(crate_dir.join("externals/zkevm-prover/test/examples/dynamic_chelpers.cpp"))
             .arg(format!("-I{}", chelpers_header_dir.to_str().unwrap()))
             .args(
-                &[
+                [
                     "src/config",
                     "src/starkpil",
                     "src/utils",
@@ -200,7 +200,7 @@ pub fn generate_proof(
                     p.canonicalize().unwrap()
                 }),
             )
-            .current_dir(&output_dir),
+            .current_dir(output_dir),
         Error::ProofGen,
     )?;
 
@@ -292,7 +292,7 @@ mod tests {
             &starkstruct_json,
             &constants_bin,
             &commits_bin,
-            &output_dir,
+            output_dir,
         )
         .expect("proof generation failed");