Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Witgen: Block machines "forget" that they already completed a block #1385

Closed
georgwiese opened this issue May 17, 2024 · 0 comments · Fixed by #1528
Closed

Witgen: Block machines "forget" that they already completed a block #1385

georgwiese opened this issue May 17, 2024 · 0 comments · Fixed by #1528
Labels
witness generation Concerning the module of automated witness derivation

Comments

@georgwiese
Copy link
Collaborator

In our BlockMachine implementation, we already have this code which should make sure that no two blocks are added for the same input / output pair.

The problem is that it only looks into the last block. If other blocks have been added in the mean time, a new block would be created if the same connecting identity was processed again.

This currently causes the permutation_to_block_to_block test to fail.
@georgwiese georgwiese mentioned this issue May 20, 2024
Merged
@leonardoalt leonardoalt added the witness generation Concerning the module of automated witness derivation label May 22, 2024
@georgwiese georgwiese mentioned this issue Jul 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@georgwiese
Block machines: Skip complete identities (#1528)
c4ded73 
Just like the `VmProcessor`, with this PR the `BlockProcessor` never
processes an identity again that has been completed.

This should be a slight performance optimization (when the "default"
sequence iterator is used), but more importantly it:
- Fixes #1385 
- Allows us to remove error-prone code (see below)
- Helps with witgen for stateful machines, like those who access memory
@georgwiese georgwiese mentioned this issue Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
witness generation Concerning the module of automated witness derivation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block machines: Skip complete identities powdr-labs/powdr
2 participants
@leonardoalt @georgwiese