Continue CompositeBackend
#1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
commented
Jun 26, 2024
| @@ -95,7 +119,7 @@ pub trait BackendFactory<F: FieldElement> { | |||
| &self, | |||
| pil: &'a Analyzed<F>, | |||
| fixed: &'a [(String, Vec<F>)], | |||
| output_dir: Option<&'a Path>, | |||
There was a problem hiding this comment.
This made it hard to change the path in the CompositeBackend. I don't see a good reason to pass a reference with a lifetime here anyway.
|
With 8f472bd, the slowest CI job now takes 16min (compared to 14min before this PR), which I think is reasonable. |
Schaeff
reviewed
Jun 26, 2024
| @@ -95,7 +119,7 @@ pub trait BackendFactory<F: FieldElement> { | |||
| &self, | |||
| pil: &'a Analyzed<F>, | |||
| fixed: &'a [(String, Vec<F>)], | |||
| output_dir: Option<&'a Path>, | |||
pipeline/src/test_util.rs
Outdated
Comment on lines
140
to
144
| #[cfg(not(feature = "halo2"))] | ||
| pub fn test_halo2(_file_name: &str, _inputs: Vec<Bn254Field>) {} | ||
|
|
||
| #[cfg(feature = "halo2")] | ||
| pub fn gen_halo2_proof(file_name: &str, inputs: Vec<Bn254Field>) { | ||
| pub fn gen_halo2_proof(file_name: &str, inputs: Vec<Bn254Field>, composite: bool) { |
There was a problem hiding this comment.
Not a fan of boolean arguments like that, if it can't be two different functions can you at least introduce an enum for the {use_}composite argument?
There was a problem hiding this comment.
I split the function.
leonardoalt
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few incremental changes towards implementing VadCop (#424):
CompositeBackendnow explicitly panics for stuff that I'm planning to defer the implementation of, like exporting verification keys."main".