BackendFactory: Use Arc instead of references
#1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
force-pushed
the
backend-use-arc
branch
from
8700934
to
f6c7c81
Compare
georgwiese
force-pushed
the
backend-use-arc
branch
from
7efb82f
to
093f808
Compare
georgwiese
changed the title
BackendFactory: Use Arc instead of referencesBackendFactory: Use Arc instead of references
leonardoalt
reviewed
Jun 28, 2024
| pil.borrow(), | ||
| &fixed_cols[..], | ||
| pil.clone(), | ||
| fixed_cols.clone(), |
There was a problem hiding this comment.
All this cloning will probably be quite slow in practice probably, no?
There was a problem hiding this comment.
No, because it's cloning Arcs!
leonardoalt
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #1470.
Receiving references, the
CompositeBackendhas no chance of changing the PIL or fixed columns before passing it to the wrapped backend. UsingArcfixed it, and is quite compatible with what is kept byPipelinealready.