Change column map to work efficiently with slices of column IDs. #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
subslice_for_column_map
branch
from
994ee9f
to
4dedcb1
Compare
chriseth
force-pushed
the
subslice_for_column_map
branch
from
4dedcb1
to
c021683
Compare
chriseth
commented
Jul 3, 2024
| @@ -458,6 +487,7 @@ impl<'row, 'a, T: FieldElement> RowPair<'row, 'a, T> { | |||
| pub fn get_value(&self, poly: &AlgebraicReference) -> Option<T> { | |||
| let row = self.get_row(poly.next); | |||
| if self.unknown_strategy == UnknownStrategy::Zero { | |||
| // TODO this should panic if the column is out of range. | |||
There was a problem hiding this comment.
Ah no, I still wanted to look into which calls to get_value should panic and which should return None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.