Speed up tests #1556
Merged
Speed up tests #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
force-pushed
the
speed-up-test
branch
from
9b826c7
to
75acdd2
Compare
georgwiese
commented
Jul 12, 2024
Comment on lines
+119
to
+122
| /// The temporary directory, owned by the pipeline (or any copies of it). | ||
| /// This object is not used directly, but keeping it here ensures that the directory | ||
| /// is not deleted until the pipeline is dropped. | ||
| _tmp_dir: Option<Rc<Temp>>, |
There was a problem hiding this comment.
This is much more convenient and save, otherwise you have to keep around the Temp object around for as long as the pipeline lives.
I think we used to do it like that before, not sure we stopped? Maybe because we wanted Pipeline to be clone-able? But the Rc does exactly what you'd want.
leonardoalt
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PRs (#1538, #1534) have significantly slowed down the CI, because they run every test twice, once with the "plain" backend and once with the
CompositeBackend.This PR makes sure that at least we only do the steps before (analyzing & optimizing PIL, fixed column computation, witness computation) only once, by making a "prepared" pipeline once and cloning it to test different backends.
This leads to a slight speed up in the tests.