Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store scopes in a stack to push/pop them in a consistent way #36

Merged
merged 2 commits into from
Feb 19, 2017

Conversation

twada
Copy link
Member

@twada twada commented Feb 19, 2017

Parent scope does not match parent function scope on leaving class
since espower handles scopes only at function level.

const assert = require('assert');
class Dog {
    say() {
        return 'bow';
        // gap occurs here
    }
}
const d = new Dog();
assert(d.say());

refs: power-assert-js/power-assert#78
refs: power-assert-js/power-assert#79

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 97.756% when pulling 5e9373f on scope-stack into 9163439 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 19, 2017

Coverage Status

Coverage increased (+0.006%) to 97.756% when pulling 5e9373f on scope-stack into 9163439 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants