fix: correct SQLite backend problem preventing zone updates from temp…

…late page, closes #538
poweradmin · Dec 17, 2023 · 828dcdd · 828dcdd
1 parent 1adfd35
commit 828dcdd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/lib/DnsRecord.php b/lib/DnsRecord.php
@@ -1182,6 +1182,7 @@ public function get_zones(string $perm, int $userid = 0, string $letterstart = '
             $this->db->setLimit($rowamount, $rowstart);
         }
         $result = $this->db->query($query);
+        $this->db->setLimit(0);
 
         $ret = array();
         while ($r = $result->fetch()) {
@@ -1311,6 +1312,7 @@ public static function get_records_from_domain_id($db, $db_type, int $id, int $r
                             FROM records
                             WHERE domain_id=" . $db->quote($id, 'integer') . " AND type IS NOT NULL
                             ORDER BY type = 'SOA' DESC, type = 'NS' DESC," . $sql_sortby);
+        $db->setLimit(0);
 
         if ($records) {
             $result = $records->fetchAll();
@@ -1629,6 +1631,8 @@ public function update_zone_records($db_type, $dns_ttl, int $zone_id, int $zone_
             if ($perm_edit == "all" || ($perm_edit == "own" && $user_is_zone_owner == "1")) {
                 if ($db_type == 'pgsql') {
                     $query = "DELETE FROM records r USING records_zone_templ rzt WHERE rzt.domain_id = :zone_id AND rzt.zone_templ_id = :zone_template_id AND r.id = rzt.record_id";
+                } else if ($db_type == 'sqlite' || $db_type == 'sqlite3') {
+                    $query = "DELETE FROM records WHERE id IN (SELECT r.id FROM records r LEFT JOIN records_zone_templ rzt ON r.id = rzt.record_id WHERE rzt.domain_id = :zone_id AND rzt.zone_templ_id = :zone_template_id)";
                 } else {
                     $query = "DELETE r, rzt FROM records r LEFT JOIN records_zone_templ rzt ON r.id = rzt.record_id WHERE rzt.domain_id = :zone_id AND rzt.zone_templ_id = :zone_template_id";
                 }
@@ -1681,7 +1685,6 @@ public function update_zone_records($db_type, $dns_ttl, int $zone_id, int $zone_
                             $record_id = $this->db->lastInsertId();
                         }
 
-                        $this->db->setLimit(0);
                         $query = "INSERT INTO records_zone_templ (domain_id, record_id, zone_templ_id) VALUES ("
                             . $this->db->quote($zone_id, 'integer') . ","
                             . $this->db->quote($record_id, 'integer') . ","

diff --git a/lib/LegacyUsers.php b/lib/LegacyUsers.php
@@ -141,6 +141,8 @@ public static function show_users($db, int|string $id = '', int $rowstart = 0, i
         // Execute the huge query.
         $db->setLimit($rowamount, $rowstart);
         $response = $db->query($query);
+        $db->setLimit(0);
+
         $ret = array();
         while ($r = $response->fetch()) {
             $ret [] = array(

diff --git a/lib/ZoneTemplate.php b/lib/ZoneTemplate.php
@@ -252,6 +252,7 @@ public static function get_zone_templ_records($db, int $id, int $rowstart = 0, i
 
         $stmt = $db->prepare("SELECT id FROM zone_templ_records WHERE zone_templ_id = :id ORDER BY " . $sortby);
         $stmt->execute([':id' => $id]);
+        $db->setLimit(0);
 
         $ret[] = array();
         $retCount = 0;