fix: Changes to the way a session is started. Resolves #547

poweradmin · Mar 7, 2024 · 84a7b0a · 84a7b0a
1 parent 4070d9f
commit 84a7b0a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 15 deletions.
diff --git a/index.php b/index.php
@@ -24,6 +24,8 @@
 
 require __DIR__ . '/vendor/autoload.php';
 
+session_start();
+
 $router = new BasicRouter(array_merge($_GET, $_POST));
 $router->setDefaultPage('index');
 $router->setPages([

diff --git a/lib/Application/Controller/LoginController.php b/lib/Application/Controller/LoginController.php
@@ -50,7 +50,6 @@ public function run(): void
         $localesData = $this->localeRepository->getLocales();
         $preparedLocales = $this->localeService->prepareLocales($localesData, $this->config('iface_lang'));
 
-        $this->initializeSession();
         list($msg, $type) = $this->getSessionMessages();
 
         if (!$this->config('ignore_install_dir') && file_exists('install')) {
@@ -60,13 +59,6 @@ public function run(): void
         }
     }
 
-    public function initializeSession(): void
-    {
-        if (session_status() === PHP_SESSION_NONE) {
-            session_start();
-        }
-    }
-
     public function getSessionMessages(): array
     {
         $msg = $_SESSION['message'] ?? '';

diff --git a/lib/Domain/Service/SessionService.php b/lib/Domain/Service/SessionService.php
@@ -26,10 +26,6 @@
 
 class SessionService {
     public function startSession(SessionEntity $sessionEntity): void {
-        if (session_status() === PHP_SESSION_NONE) {
-            session_start();
-        }
-
         $this->setSessionData($sessionEntity);
     }
 

diff --git a/lib/LegacyApplicationInitializer.php b/lib/LegacyApplicationInitializer.php
@@ -36,7 +36,7 @@ class LegacyApplicationInitializer
     public function __construct(bool $authenticate)
     {
         $this->checkConfigurationFile();
-        $this->initializeSessionAndDependencies();
+        $this->checkDependencies();
         $this->loadConfiguration();
         $this->connectToDatabase();
         if ($authenticate) {
@@ -54,9 +54,8 @@ private function checkConfigurationFile(): void
         }
     }
 
-    private function initializeSessionAndDependencies(): void
+    private function checkDependencies(): void
     {
-        session_start();
         DependencyCheck::verifyExtensions();
     }