Avoid querying for pdnssec ordering records at all #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "WHERE" filters for TYPE IS NULL to record queries Previous fix in Fix poweradmin#194 only hides them from display, which results in empty pages, incorrect pagination and random numbers of records per page. PowerAdmin shouldn't need to see these at all so filter them at SQL.
stasic
added a commit
that referenced
this pull request
Oct 24, 2014
Avoid querying for pdnssec ordering records at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "WHERE" filters for TYPE IS NULL to record queries
Previous fix in Fix #194 only hides them from display, which
results in empty pages, incorrect pagination and random numbers
of records per page. PowerAdmin shouldn't need to see these at all
so filter them at SQL.