Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update records only if they have been changed #237

Merged

Conversation

JonasGroeger
Copy link
Contributor

Prior, for every zone change, all records in the database were
updated. This patch improves upon that so that only changed records
in a zone are updated in the database.

The zone comment is still unchecked. A new serial will be generated,
even if there is no record change.

This fixes #234, #166.

Prior, for every zone change, all records in the database were
updated. This patch improves upon that so that only changed records
in a zone are updated in the database.

The zone comment is still unchecked. A new serial will be generated,
even if there is no record change.
@JonasGroeger
Copy link
Contributor Author

@eg Any chance this will get reviewed?

@edmondas edmondas added this to the v2.1.8 milestone Jul 14, 2015
@edmondas edmondas self-assigned this Jul 14, 2015
@edmondas
Copy link
Contributor

Thanks.

edmondas pushed a commit that referenced this pull request Jul 14, 2015
…gedRecords

Update records only if they have been changed
@edmondas edmondas merged commit c49908e into poweradmin:master Jul 14, 2015
@RavenB
Copy link

RavenB commented Jul 14, 2015

Can we still have the option to do a full zone refresh ? This seems no longer be possible.
Although the update is nice, sometimes we might wish to have a full refresh. (ie can this be corrected to allow us to choose ?) or have a an option somewhere to have full refresh. (without needing to to go the pdns_tools itself.) Or does a full refresh still occur ?

@JonasGroeger
Copy link
Contributor Author

@RavenB What exactly do you mean with "full refresh"?

@edmondas
Copy link
Contributor

Zone transfer is still possible, because serial number is updated even there are no changes in records.
But situation changes if you use 0 for serial number and according to PowerDNS documentation:

If left at 0, the default, PDNS will perform an internal list of the domain to determine highest change_date field of all records within the zone, and use that as the zone serial number. This means that the serial number is always raised when changes are made to the zone, as long as the change_date field is being set.

So after @JonasGroeger changes you will not be able to do "full refresh".

@JonasGroeger JonasGroeger deleted the feature/234-UpdateOnlyChangedRecords branch August 6, 2015 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a single resource record writes updates for all resource records, even if they did not change
3 participants