Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor puller ipc timeout #155

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Refactor puller ipc timeout #155

merged 4 commits into from
Apr 12, 2023

Conversation

gfieni
Copy link
Contributor

@gfieni gfieni commented Apr 12, 2023

PR overview:

  • Uses the socket_interface global timeout instead of the fixed 0.1 second value for receive_control method ;
  • Adds a FakeDispatcher class for the tests ;
  • Improves the Puller unit tests with more concrete tests cases.

@gfieni gfieni self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #155 (553913c) into master (5999793) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 553913c differs from pull request most recent head a3ec169. Consider uploading reports for the commit a3ec169 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   60.69%   60.70%           
=======================================
  Files          85       85           
  Lines        3132     3130    -2     
=======================================
- Hits         1901     1900    -1     
+ Misses       1231     1230    -1     
Impacted Files Coverage Δ
powerapi/actor/actor.py 52.04% <ø> (+0.04%) ⬆️
powerapi/puller/handlers.py 27.67% <0.00%> (ø)
powerapi/puller/puller_actor.py 92.59% <0.00%> (ø)

@gfieni gfieni merged commit 2b1b70d into master Apr 12, 2023
4 checks passed
@gfieni gfieni deleted the refactor/puller-ipc-timeout branch April 12, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant