Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/issue209/prometheus consolidation #210

Merged
merged 11 commits into from
Nov 22, 2023
Merged

Refactor/issue209/prometheus consolidation #210

merged 11 commits into from
Nov 22, 2023

Conversation

roda82
Copy link
Contributor

@roda82 roda82 commented Nov 20, 2023

Closes: #209

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited

Codecov Report

Merging #210 (e60f2f6) into master (23e74eb) will increase coverage by 0.89%.
Report is 2 commits behind head on master.
The diff coverage is 31.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   65.62%   66.52%   +0.89%     
==========================================
  Files          88       87       -1     
  Lines        3782     3710      -72     
==========================================
- Hits         2482     2468      -14     
+ Misses       1300     1242      -58
Files Coverage Δ
powerapi/cli/config_parser.py 91.52% <100.00%> (ø)
powerapi/cli/generator.py 81.86% <100.00%> (ø)
powerapi/database/__init__.py 100.00% <ø> (ø)
...pi/processor/pre/k8s/k8s_pre_processor_handlers.py 46.66% <0.00%> (-2.18%) ⬇️
powerapi/pusher/handlers.py 35.29% <14.28%> (-1.38%) ⬇️
powerapi/cli/common_cli_parsing_manager.py 0.00% <0.00%> (ø)
powerapi/database/prometheus_db.py 53.33% <47.05%> (+12.28%) ⬆️

@gfieni gfieni self-requested a review November 20, 2023 10:09
@roda82
fix: Correct bug related to arguments default values not added to con…
eda819c 
…figuration when those arguments are not defined
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2023
View reviewed changes
tests/unit/cli/conftest.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2023
View reviewed changes
tests/unit/cli/conftest.py Dismissed Show dismissed Hide dismissed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfieni gfieni merged commit 80ce800 into master Nov 22, 2023
8 checks passed
@gfieni gfieni deleted the refactor/issue209/prometheus-consolidation branch November 22, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfieni gfieni gfieni approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidating the implementation of the prometheus destination
2 participants
@roda82 @gfieni