This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Added Scraping Hacker news website script #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neilblaze
suggested changes
Aug 16, 2020
| if len(vote): #To check if class "score" exists or not | ||
| points = int(vote[0].getText().replace(' points', '')) | ||
| if points > 100: # To get votes/points more than 100 | ||
| hackerNews.append({'title': title, 'link': href,'votes':points}) |
There was a problem hiding this comment.
Update it to this ⬇
hackerNews.append({'title': title, 'link': href, 'votes': points})
Follow good code practice - here
Signed by - @Neilblaze
| ''' | ||
| Program uses requests module to get web data from URL and BeautifulSoup module to parse the web data | ||
| as HTML using html parser. | ||
| Install requests and BeautifulSoup module before executing! |
There was a problem hiding this comment.
LGTM 👍
Better add README (guide) along with this inside the folder same as your <filename> & you're good to go!
Signed by - @Neilblaze
There was a problem hiding this comment.
Okay. I will add readme inside the folder
|
@Neilblaze I have made the changes.Please check now |
|
Good job @GudlaArunKumar 🎉 |
Neilblaze
approved these changes
Aug 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#CH20
Issue #92
About PR: Created script for scraping the first 2 pages of Hacker news website wherein user can read some cool tech news as articles which has Upvotes more than 100.