Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Medium Articles Details Scrapper #125

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Conversation

kaustubhgupta
Copy link
Contributor

Issue: #92
This script will generate a CSV file containing details about various medium articles published by a specific publication on a given date range. The number dates can be specified and all dates are chosen randomly.

image

Copy link
Collaborator

@SKAUL05 SKAUL05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. CQ is very good. Follow the changes requested.

from app import Scrap


a = Scrap(urls_dict={"Towards Data Science": "https://towardsdatascience.com",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Dynamic Inputs instead of hardcoded ones

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my side!

import time

class Scrap:
"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaustubhgupta it'll be recommended if you shift this comment part to the README as it's description part!

@kaustubhgupta
Copy link
Contributor Author

Hey @SKAUL05 & @Neilblaze , I have made the required changes. Please review and let me know if it can be merged now.

image

@powerexploit
Copy link
Owner

Hey @SKAUL05 & @Neilblaze , I have made the required changes. Please review and let me know if it can be merged now.

image

@kaustubhgupta Nice contributions also add the screenshot in the folder.
Then we I @ankitdobhal (PA) will merge the PR.
Thanks

@kaustubhgupta
Copy link
Contributor Author

@ankitdobhal Done with the screenshot!

@powerexploit powerexploit merged commit 8ec4b27 into powerexploit:master Aug 17, 2020
@kaustubhgupta kaustubhgupta deleted the dev branch August 17, 2020 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants