Fix for the final training of the train method for backwards models #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thank you for your contribution Bernd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: Nice work on the package!
When training a backward model with multiple regularization values, the last
_traincall on line 255 usesstimuliandresponsesinstead ofxsandys(as on line 185 in mtrf/model.py), leading to wrong weights and biases.In my case, this was not obvious until
predictwas called andnumpyraised aValueErrorbecause the reshaping of the weights failed. I've adapted the unittest forpredictto catch this issue, in case it would re-appear.Kind regards,
Bernd