-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding update to retry if 0 filtered found #332
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: prubenda <prubenda@redhat.com>
df33ddf
to
ddd0995
Compare
Hi and thanks so much for the PR! I was just reading through the code. Could you please give me a use-case for where this is helpful? Many thanks! |
Hi @seeker89,
|
@paigerube14 thanks, now it makes so much more sense! |
Thanks so much @seeker89 |
Changing the returned values from the action_nodes_pods.execute function to continue looping until the timeout or count has been hit
Everything should execute the same, except for when we want to run retries, if the filtered list is 0 and we expect a number it should keep attempting to execute
Fixes: #331