New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for date segment to take a timezone argument #1337
Support for date segment to take a timezone argument #1337
Conversation
install_requires=[], | ||
install_requires=[ | ||
'pytz' | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should make this optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying making the feature altogether optional if they have pytz installed? That makes sense.
I have no idea if I did the optional bits correctly but it seems work correctly with pytz installed and not and raises proper errors when trying to use unavailable functionality |
|
||
Divider highlight group used: ``time:divider``. | ||
|
||
Highlight groups used: ``time`` or ``date``. | ||
''' | ||
|
||
if (tz): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not use parenthesis here.
While I like the idea of the
|
I wanted the functionally to have two clocks of different timezones in my powerline, this did the trick.