Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate a right prompt in bash #2148

Merged

Conversation

sdrik
Copy link
Contributor

@sdrik sdrik commented Jan 2, 2021

Fixes #2103

@PH111P
Copy link
Member

PH111P commented Jan 4, 2021

This looks very nice!
(Although, I must admit that it does not look as "trivial" as I would have imagined it to be, so it appears I was wrong with my assessment in that regard; so all the more, thanks for your contribution!)

Some comments:

  • Allowing to pass arguments from render to hl and hlstyle is probably a good idea, so although this makes this PR look slightly messy, it is a good change in my opinion. However, please add the argument (hl_args) to the corresponding documentation as well. (In particular in renderer.py.)

@PH111P PH111P merged commit c31f83f into powerline:develop Jan 6, 2021
@sdrik sdrik deleted the feature/2103-emulate-bash-right-prompt branch January 6, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How hard would it be to have a right prompt in bash?
2 participants