fix: use aarch64 suffix instead of arm64 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, arm64 architecture is commonly referred to as aarch64. The `uname -m` command returns the latter. As a result, the command suggested in the README to install dockerize doesn't work on this architecture. This commit fixes this by renaming the release artifact from "linux-arm64" to "linux-aarch64". Thus, "$(uname -s)-$(uname -m)" will return the expected artifact name. See also: https://stackoverflow.com/a/45125525
|
Accordingly to https://en.wikipedia.org/wiki/Uname |
|
Isn't MacOS+arm64 supposed to be a different ELF format (which is unsupported right now)? Like |
|
Anyways, just added |
powerman
approved these changes
Feb 28, 2023
|
Thanks! |
|
Released 0.18.2, please test new aarch64 binary. :) |
|
Works like a charm. Thanks for the release 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, arm64 architecture is commonly referred to as aarch64. The
uname -mcommand returns the latter. As a result, the command suggested in the README to install dockerize doesn't work on this architecture.This commit fixes this by renaming the release artifact from "linux-arm64" to "linux-aarch64". Thus, "$(uname -s)-$(uname -m)" will return the expected artifact name.
See also: https://stackoverflow.com/a/45125525
Note that this may be surprising to users currently expecting the
-arm64suffix. If necessary, we can consider providing both artifacts, but that sounds wrong.