Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support perl down to 5.8.1 #8

Merged
merged 2 commits into from Jan 9, 2018
Merged

Support perl down to 5.8.1 #8

merged 2 commits into from Jan 9, 2018

Conversation

ilmari
Copy link
Contributor

@ilmari ilmari commented Jan 9, 2018

This module is used by Devel::Cover::Report::Codecov, which would
otherwise work on 5.8.1.

@coveralls
Copy link

coveralls commented Jan 9, 2018

Coverage Status

Coverage increased (+0.3%) to 84.79% when pulling 8487b20 on ilmari:perl-5.8 into 71246ef on powerman:master.

This module is used by Devel::Cover::Report::Codecov, which would
otherwise work on 5.8.1.
@coveralls
Copy link

coveralls commented Jan 9, 2018

Coverage Status

Coverage increased (+0.3%) to 84.79% when pulling cf9daea on ilmari:perl-5.8 into 71246ef on powerman:master.

@coveralls
Copy link

coveralls commented Jan 9, 2018

Coverage Status

Coverage increased (+0.3%) to 84.79% when pulling ce35993 on ilmari:perl-5.8 into 71246ef on powerman:master.

- Use the travis-perl helper, to install a working Devel::Cover on 5.8.
- Allow Mojolicious install to fail, since it requires 5.10
@powerman
Copy link
Owner

powerman commented Jan 9, 2018

Looks like it's a bit too early for PR - Travis fails. Ping me when you'll finish with it, please.

@coveralls
Copy link

coveralls commented Jan 9, 2018

Coverage Status

Coverage increased (+0.3%) to 84.839% when pulling d6dc31a on ilmari:perl-5.8 into 71246ef on powerman:master.

@ilmari
Copy link
Contributor Author

ilmari commented Jan 9, 2018

Sorry, I messed up adjusting .travis.yml, should be fixed now.

The only failure in the latest build is because a networking glitch, you might want to try restarting https://travis-ci.org/powerman/perl-Test-Mock-Time/jobs/326877393.

@ilmari
Copy link
Contributor Author

ilmari commented Jan 9, 2018

The warnings from the tests on 5.8 are harmless, but can be silenced by bumping the Time::HiRes dependency to 1.9724.

@powerman
Copy link
Owner

powerman commented Jan 9, 2018

@ilmari Is it possible to somehow address issue with warning Prototype mismatch: sub Time::HiRes::clock_nanosleep ($$;$) vs () at /home/travis/perl5/perlbrew/perls/5.8/lib/site_perl/5.8.8/Test/MockModule.pm line 154 during global destruction. on 5.8? If every script running on 5.8 will have this warning on exit, then this doesn't looks good enough to me.

@powerman
Copy link
Owner

powerman commented Jan 9, 2018

@ilmari Oh, sorry, just noticed you've already answered this.

@powerman powerman merged commit 0bb24c6 into powerman:master Jan 9, 2018
@powerman
Copy link
Owner

powerman commented Jan 9, 2018

v0.1.7 just released. Thanks!

@ilmari ilmari deleted the perl-5.8 branch January 10, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants