Mockito Public API Support Roadmap #726

thekingn0thing · 2016-12-01T07:16:51Z

Powermock is heavily relying on the internal workings of Mockito. As result hight cost of compatibility maintenance. We should move to using public SPI. Mockito team is ready to help and provide change in API.

Main goal: clean code without dirty hacks to get internals of Mockito.

We need:

Identify using of Mockito internals and create a change request for Mockito
Replace using internals of Mockito with using public API.
Use delegate MockMaker to prevent issue with replacing Mockito MockMaker when PowerMock in class path (see PowerMockMaker with Mockito2 #769, Fixes #1003: Allow reloading of plugins. mockito/mockito#1004)
Reporter - now internal, need ability to show custom message if mocking is failed for static methods
Drop supporting Mockito 1.

Current mockito 2 compatibility issues:

java.lang.IllegalAccessError: tried to access method org.mockito.internal.util.ObjectMethodsGuru.<init> #720 java.lang.IllegalAccessError: tried to access method org.mockito.internal.util.ObjectMethodsGuru.
PowerMockito not compatible Mockito2 since their v2.0.55-beta release #706 PowerMockito not compatible Mockito2 since their v2.0.55-beta release
java.lang.NoClassDefFoundError: org/mockito/MockitoAnnotations$Mock #678 java.lang.NoClassDefFoundError: org/mockito/MockitoAnnotations$Mock
Problem when building Mocktio2 with gradle #681 Problem when building Mocktio2 with gradle
java.lang.NoClassDefFoundError: org/mockito/exceptions/Reporter #684 java.lang.NoClassDefFoundError: org/mockito/exceptions/Reporter
Crash with latest mockito2 #686 Crash with latest mockito2
AbstractMethodError when used with Mockito 2.1.0 #700 AbstractMethodError when used with Mockito 2.1.0
can't mock final methods with powermock-mockito2 1.7.0.RC4 and mockito2 inline feature enabled #774 can't mock final methods with powermock-mockito2 1.7.0.RC4 and mockito2 inline feature enabled

zyl0501 · 2016-12-26T09:01:41Z

How to use PowerMockito.mockStatic()?
It return error when I call this method, like https://github.com/powermock/powermock/issues/720.
What is the alternative?

thekingn0thing · 2016-12-27T09:20:33Z

@zyl0501,

Unfortunately, there is no alternative, except use PowerMock with Mockito 1.

thekingn0thing · 2017-02-04T17:41:22Z

Experimental supporting Mockito 2.4.0 has been added in PowerMock 1.7.0RC in pull request #740

ChristianSchwarz · 2017-02-10T11:43:58Z

@thekingnothing
I am contributing to mockito, if you need support or additional APIs for Mockito 2 let me know, i try to help!

TheKlint · 2017-03-22T13:36:30Z

I am trying to use the combo below - but I still get "Exception in thread "main" java.lang.NoClassDefFoundError: org/mockito/exceptions/Reporter"

Is there currently any working combo for Mockito 2 and PowerMockito.mockStatic()?

testCompile 'junit:junit:4.12'
testCompile 'org.mockito:mockito-core:2.4.0'
testCompile "org.powermock:powermock-module-junit4:1.7.0RC2"
testCompile "org.powermock:powermock-api-mockito:1.7.0RC2"

thekingn0thing · 2017-03-23T18:51:37Z

@TheKlint, could you provide full stack trace? How throw exception?

HCL-Balaji · 2017-04-04T11:08:32Z

@thekingnothing I think below exception is mentioned by @TheKlint

Exception in thread "main" java.lang.NoClassDefFoundError: org/mockito/exceptions/Reporter
	at sun.reflect.GeneratedSerializationConstructorAccessor5.newInstance(Unknown Source)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:45)
	at org.powermock.reflect.internal.WhiteboxImpl.newInstance(WhiteboxImpl.java:260)
	at org.powermock.reflect.Whitebox.newInstance(Whitebox.java:139)
	at org.powermock.api.extension.reporter.AbstractMockingFrameworkReporterFactory.getInstanceForClassLoader(AbstractMockingFrameworkReporterFactory.java:41)
	at org.powermock.api.extension.reporter.AbstractMockingFrameworkReporterFactory.create(AbstractMockingFrameworkReporterFactory.java:35)
	at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.getMockingFrameworkReporter(JUnit4TestSuiteChunkerImpl.java:140)
	at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:119)
	at org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:53)
	at org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
Caused by: java.lang.ClassNotFoundException: org.mockito.exceptions.Reporter
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at org.powermock.core.classloader.MockClassLoader.loadModifiedClass(MockClassLoader.java:190)
	at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass1(DeferSupportingClassLoader.java:77)
	at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass(DeferSupportingClassLoader.java:67)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	... 21 more

AlekseiMarkov · 2017-04-06T01:52:35Z

Hi, same problem
powermock 1.7.0RC2
org.mockito:mockito-core 2.4.0

Exception in thread "main" java.lang.NoClassDefFoundError: org/mockito/exceptions/Reporter at sun.reflect.GeneratedSerializationConstructorAccessor4.newInstance(Unknown Source) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:45) at org.powermock.reflect.internal.WhiteboxImpl.newInstance(WhiteboxImpl.java:260) at org.powermock.reflect.Whitebox.newInstance(Whitebox.java:139) at org.powermock.api.extension.reporter.AbstractMockingFrameworkReporterFactory.getInstanceForClassLoader(AbstractMockingFrameworkReporterFactory.java:41) at org.powermock.api.extension.reporter.AbstractMockingFrameworkReporterFactory.create(AbstractMockingFrameworkReporterFactory.java:35) at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.getMockingFrameworkReporter(JUnit4TestSuiteChunkerImpl.java:140) at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:119) at org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:53) at org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59) at org.junit.runner.JUnitCore.run(JUnitCore.java:160) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)

drayan85 · 2017-04-13T09:22:35Z

I am facing the same issue with below configuration.
testCompile 'org.mockito:mockito-core:2.4.0'
testCompile 'org.powermock:powermock-module-junit4:1.7.0RC2'
testCompile 'org.powermock:powermock-api-mockito:1.7.0RC2'

java.lang.NoClassDefFoundError: org/mockito/exceptions/Reporter
at sun.reflect.GeneratedSerializationConstructorAccessor5.newInstance(Unknown Source) at java.lang.reflect.Constructor.newInstance(Constructor.java:408) at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:45) at org.powermock.reflect.internal.WhiteboxImpl.newInstance(WhiteboxImpl.java:260) at org.powermock.reflect.Whitebox.newInstance(Whitebox.java:139) at org.powermock.api.extension.reporter.AbstractMockingFrameworkReporterFactory.getInstanceForClassLoader(AbstractMockingFrameworkReporterFactory.java:41) at org.powermock.api.extension.reporter.AbstractMockingFrameworkReporterFactory.create(AbstractMockingFrameworkReporterFactory.java:35) at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.getMockingFrameworkReporter(JUnit4TestSuiteChunkerImpl.java:140) at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:119) at org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:53) at org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:117) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:262) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:84) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:483) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
Caused by: java.lang.ClassNotFoundException: org.mockito.exceptions.Reporter
at java.net.URLClassLoader$1.run(URLClassLoader.java:372) at java.net.URLClassLoader$1.run(URLClassLoader.java:361) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:360) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at org.powermock.core.classloader.MockClassLoader.loadModifiedClass(MockClassLoader.java:190) at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass1(DeferSupportingClassLoader.java:77) at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass(DeferSupportingClassLoader.java:67) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 29 more

thekingn0thing · 2017-04-14T10:51:09Z

@TheKlint @HCL-Balaji @drayan85 @AlekseiMarkov

I am trying to use the combo below - but I still get "Exception in thread "main" java.lang.NoClassDefFoundError: org/mockito/exceptions/Reporter"

Please, check dependencies, to use PowerMock with Mockito 2+ it should be not a
testCompile "org.powermock:powermock-api-mockito:1.7.0RC2"

but

org.powermock:powermock-api-mockito2:1.7.0RC2

https://github.com/powermock/powermock/wiki/Mockito-2-(Maven)

drayan85 · 2017-04-17T02:18:38Z

@thekingnothing , thanks . with mokito2 working for now.

Use a new MockSetting API when mock is being created.

Use Mockito Public API to create a mock

Refactoring to isolate Mockito internal code.

Stianhn · 2017-07-24T09:18:13Z

@thekingnothing All the "current mockito 2 compatibility issues" listed in the first post are closed, but the wiki still states that Mockito2 support is experimental. What has to be in place before the Mockito2 support is no longer experimental?

thekingn0thing · 2017-07-24T13:19:28Z

The mockito/mockito#1110<https://github.com/mockito/mockito/issues/1110#issuecomment-317418861> should be closed before make supporting Mockito 2 official stable. We still have some issues, for example cleaning/reset mock could work incorrectly. Things like checking if class ready for static mock was just commented out. Best regrads, Arthur Zagretdinov On 24 Jul 2017, at 11:18, Stian H. Nesbø <notifications@github.com<mailto:notifications@github.com>> wrote: All the "current mockito 2 compatibility issues" listed in the first post are closed, but the wiki still states that Mockito2 support is experimental. What has to be in place before the Mockito2 support is no longer experimental? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub<#726 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMkKADn8j3noP4H41n7JGVXZd8jUoKSyks5sRGFZgaJpZM4LBEt2>.