Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Add test for having a new line at the end of a file #31

Closed
dcrreynolds opened this issue Feb 11, 2016 · 4 comments
Closed

Add test for having a new line at the end of a file #31

dcrreynolds opened this issue Feb 11, 2016 · 4 comments
Assignees

Comments

@dcrreynolds
Copy link
Contributor

This has come up a number of times in peer review and would be nice to automate.

@PlagueHO
Copy link
Contributor

👍 This would be pretty easy to add I think.

@TravisEz13 TravisEz13 self-assigned this Mar 24, 2016
TravisEz13 added a commit that referenced this issue Mar 24, 2016
Revert "Resolves #31, Added test and fixer for text files ending with new lines"
@dcrreynolds
Copy link
Contributor Author

Ran the test against the default branch of all the DSC repos (count was 55). 17 had at least 1 file missing a new line.

xAzurePack, xAzureStorage, xCertificate, xDefender, xDnsServer, xExchange, xMySql, xNetworking, xPendingReboot, xPSDesiredStateConfiguration, xRemoteDesktopSessionHost, xRobocopy, xSharePoint, xSqlPs, xSQLServer, xStorage, xWindowsEventForwarding.

@KarolKaczmarek
Copy link
Contributor

Thanks @dcrreynolds! Can you reopen pull requests with those tests, similar to #33 which unfortunately was merged and reverted ?
@mbreakey3 Can you add those new lines when you will be going through PSSA errors for these modules?

@KarolKaczmarek KarolKaczmarek reopened this Apr 1, 2016
@dcrreynolds
Copy link
Contributor Author

Done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants