Fix a bug where shortcut preferences were not loaded successfully on …

…macOS This was because the settings keys for shortcuts contain the '.' character, which was also being used to encode the key's hierarchy instead of '/', so the setting was being loaded into a different path in the hierarchy. I'm not sure why this was originally done since '/' seems to still be a valid character for keys in plist files.
powertab · Sep 17, 2023 · ae699bb · ae699bb
1 parent 9b9cb6f
commit ae699bb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ Thanks to the following contributors who worked on this release:
 - Updated the minimum required version of `RtMidi` to 4.0
 
 ### Fixed
+- Fixed a bug that caused some preferences such as custom shortcuts to not persist on macOS. Note that all other preferences (such as MIDI settings) are reset by this fix and will need to be manually changed to the desired values (#447).
 - Fixed a frequent crash when the preference to play inserted notes while editing is enabled
 - Fixed potential crashes when importing Guitar Pro files (#442, #444)
 - Fixed a bug where the scroll bar's range did not update when the visible height of the score shrank (#443)

diff --git a/source/util/settingstree_plist.mm b/source/util/settingstree_plist.mm
@@ -88,7 +88,7 @@ void operator()(const SettingMap &map)
         {
             std::string prev_key = myKey;
             if (!myKey.empty())
-                myKey += ".";
+                myKey += "/";
             myKey += pair.first;
 
             auto obj = std::visit(PListValueVisitor(), pair.second);
@@ -160,7 +160,6 @@ static SettingValue converToSettingValue(NSObject *obj)
     for (NSString *key in [dict allKeys])
     {
         std::string key_str([key UTF8String]);
-        boost::replace_all(key_str, ".", "/");
 
         NSObject *obj = [prefs objectForKey:key];
         setImpl(key_str, converToSettingValue(obj));