Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BuilderDeclaration.java #143

Closed
boretti opened this issue Apr 30, 2018 · 0 comments
Closed

Refactor BuilderDeclaration.java #143

boretti opened this issue Apr 30, 2018 · 0 comments
Assignees
Labels

Comments

@boretti
Copy link
Member

boretti commented Apr 30, 2018

I've selected BuilderDeclaration.java for refactoring, which is a module of 11 lines of code and 27 incoming calls. Addressing this will make our codebase more maintainable and improve Better Code Hub's Separate Concerns in Modules guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Avoid large modules with high fan-in (nr. of incoming calls).
  • Why
    This keeps the codebase loosely coupled which makes it easier to minimize the consequences of changes.
  • How 🔧
    Identify and extract responsibilities of large modules into smaller ones and hide implementation details behind interfaces. Target having modules that have no more than 10 incoming calls.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

boretti added a commit that referenced this issue May 12, 2018
@boretti boretti self-assigned this May 13, 2018
boretti added a commit that referenced this issue May 13, 2018
boretti added a commit that referenced this issue May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant