Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick win from code beat #170

Merged
merged 5 commits into from
May 22, 2018
Merged

Fix quick win from code beat #170

merged 5 commits into from
May 22, 2018

Conversation

boretti
Copy link
Member

@boretti boretti commented May 22, 2018

No description provided.

@boretti boretti added this to the 0.2.0 milestone May 22, 2018
@boretti boretti self-assigned this May 22, 2018
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #170 into master will decrease coverage by 0.07%.
The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
- Coverage     98.23%   98.16%   -0.08%     
- Complexity      535      547      +12     
============================================
  Files            81       82       +1     
  Lines          1304     1308       +4     
  Branches         47       48       +1     
============================================
+ Hits           1281     1284       +3     
- Misses           14       15       +1     
  Partials          9        9
Flag Coverage Δ Complexity Δ
#compilerlinuxopenjdk8 92.95% <80.64%> (-0.37%) 491 <11> (+8)
#compilerlinuxoraclejdk8 92.95% <80.64%> (-0.37%) 491 <11> (+8)
#compilerlinuxoraclejdk9 93.04% <83.87%> (-0.37%) 491 <11> (+8)
#compilerosx 92.95% <80.64%> (-0.37%) 491 <11> (+8)
#unitlinuxopenjdk8 60.18% <64.51%> (+0.58%) 361 <13> (+12) ⬆️
#unitlinuxoraclejdk8 60.18% <64.51%> (+0.58%) 361 <13> (+12) ⬆️
#unitlinuxoraclejdk9 60.24% <64.51%> (+0.58%) 361 <13> (+12) ⬆️
#unitosx 60.18% <64.51%> (+0.58%) 361 <13> (+12) ⬆️
Impacted Files Coverage Δ Complexity Δ
...erunit/extensions/matchers/common/CommonUtils.java 100% <100%> (ø) 10 <2> (+2) ⬆️
...s/matchers/common/ProcessingEnvironmentHelper.java 100% <100%> (ø) 7 <7> (?)
...t/extensions/matchers/common/FileObjectHelper.java 100% <100%> (ø) 3 <2> (+2) ⬆️
...ensions/matchers/common/AbstractElementMirror.java 100% <100%> (ø) 13 <1> (+1) ⬆️
...unit/extensions/matchers/common/FactoryHelper.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...ensions/matchers/provideprocessor/RoundMirror.java 100% <100%> (ø) 20 <1> (ø) ⬇️
...n/AbstractRoundMirrorReferenceToProcessingEnv.java 100% <100%> (ø) 4 <0> (ø) ⬇️
...cessor/ProvidesMatchersAnnotatedElementMirror.java 97.89% <88.88%> (-1.12%) 27 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e47220a...eb53463. Read the comment docs.

@coveralls
Copy link

coveralls commented May 22, 2018

Pull Request Test Coverage Report for Build 841

  • 20 of 31 (64.52%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 61.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/RoundMirror.java 0 2 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/ProvidesMatchersAnnotatedElementMirror.java 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/ProvidesMatchersAnnotatedElementMirror.java 1 44.09%
Totals Coverage Status
Change from base Build 833: 0.6%
Covered Lines: 803
Relevant Lines: 1306

💛 - Coveralls

@boretti boretti merged commit 3075997 into master May 22, 2018
@boretti boretti deleted the codebeat-cleanup branch May 22, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants