Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #291 - Initial integration of jackson #323

Merged
merged 2 commits into from May 22, 2020
Merged

Issue #291 - Initial integration of jackson #323

merged 2 commits into from May 22, 2020

Conversation

boretti
Copy link
Member

@boretti boretti commented May 22, 2020

No description provided.

@boretti boretti added this to the 0.2.0 milestone May 22, 2020
@boretti boretti self-assigned this May 22, 2020
@boretti boretti linked an issue May 22, 2020 that may be closed by this pull request
Add additionnal matcher for Jackson object #291
Closed
@boretti boretti added this to In progress - Pull request in Version 0.2.0 via automation May 22, 2020
@boretti boretti marked this pull request as draft May 22, 2020 09:32
@coveralls
Copy link

coveralls commented May 22, 2020 •
edited

Pull Request Test Coverage Report for Build 2055

  • 5 of 19 (26.32%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 52.963%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/extension/jackson/DefaultJsonNodeJacksonAutomatedExtension.java 2 7 28.57%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/extension/jackson/AbstractJacksonAutomatedExtension.java 3 12 25.0%
Totals Coverage Status
Change from base Build 2049: -0.4%
Covered Lines: 715
Relevant Lines: 1350
💛 - Coveralls

@codecov
Copy link

codecov bot commented May 22, 2020 •
edited

Codecov Report

Merging #323 into master will increase coverage by 0.02%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #323      +/-   ##
============================================
+ Coverage     98.27%   98.30%   +0.02%     
- Complexity      321      324       +3     
============================================
  Files            78       80       +2     
  Lines          1333     1353      +20     
  Branches         50       53       +3     
============================================
+ Hits           1310     1330      +20     
  Misses           23       23
Flag Coverage Δ Complexity Δ
#compilerbeanmatchersitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerbeanmatchersitjdk8missinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerbeanmatchersitjdk9existinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerbeanmatchersitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerbeanmatchersitjdk9missinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerbeanmatchersitjdk9missinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerfullitjdk8linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerfullitjdk9linuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerfullitjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestdateitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestdateitjdk8missinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestdateitjdk9existinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerhamcrestdateitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestdateitjdk9missinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerhamcrestdateitjdk9missinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestutilityitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestutilityitjdk8missinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestutilityitjdk9existinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerhamcrestutilityitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerhamcrestutilityitjdk9missinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerhamcrestutilityitjdk9missinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerjacksonitjdk8existinglinuxopenjdk8 100.00% <ø> (?) 0.00 <ø> (?)
#compilerjacksonitjdk9existinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerjacksonitjdk9existinglinuxoraclejdk9 100.00% <ø> (?) 0.00 <ø> (?)
#compilerlinuxopenjdk10 63.78% <80.00%> (?) 0.00 <0.00> (?)
#compilerlinuxopenjdk8 63.87% <80.00%> (+11.81%) 0.00 <0.00> (ø)
#compilerlinuxoraclejdk9 63.78% <80.00%> (+11.64%) 0.00 <0.00> (ø)
#compilerproviderfactorydisableditjdk9linuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerproviderfactorydisableditjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerproviderfactorydisableditjdklinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerproviderfactoryenableditjdk9linuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#compilerproviderfactoryenableditjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerproviderfactoryenableditjdklinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk8hamcrest21linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk8hamcrest22linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk8linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk8missinghamcrestlinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk9hamcrest21linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk9hamcrest22linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilersimpleitjdk9missinghamcrestlinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerspotifyitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerspotifyitjdk8missinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerspotifyitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerspotifyitjdk9missinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerwrongannotationitjdk8linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#compilerwrongannotationitjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#fulllinuxopenjdk8 98.07% <95.00%> (+0.02%) 0.00 <0.00> (ø)
#fulllinuxoraclejdk9 98.00% <95.00%> (+0.02%) 0.00 <0.00> (ø)
#unitbeanmatchersitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitbeanmatchersitjdk9existinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#unitbeanmatchersitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitfullitjdk8linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitfullitjdk9linuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#unitfullitjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unithamcrestdateitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unithamcrestdateitjdk9existinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#unithamcrestdateitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unithamcrestutilityitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unithamcrestutilityitjdk9existinglinuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#unithamcrestutilityitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitlinuxopenjdk10 51.73% <25.00%> (?) 324.00 <3.00> (?)
#unitlinuxopenjdk8 51.66% <25.00%> (-0.41%) 324.00 <3.00> (+3.00) ⬇️
#unitlinuxoraclejdk9 51.73% <25.00%> (-0.41%) 324.00 <3.00> (+3.00) ⬇️
#unitproviderfactorydisableditjdk9linuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#unitproviderfactorydisableditjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitproviderfactorydisableditjdklinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitproviderfactoryenableditjdk9linuxopenjdk10 100.00% <ø> (?) 0.00 <ø> (?)
#unitproviderfactoryenableditjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitproviderfactoryenableditjdklinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitsimpleitjdk8hamcrest21linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitsimpleitjdk8hamcrest22linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitsimpleitjdk8linuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitsimpleitjdk9hamcrest21linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitsimpleitjdk9hamcrest22linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitsimpleitjdk9linuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitspotifyitjdk8existinglinuxopenjdk8 100.00% <ø> (ø) 0.00 <ø> (ø)
#unitspotifyitjdk9existinglinuxoraclejdk9 100.00% <ø> (ø) 0.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ensions/matchers/provideprocessor/RoundMirror.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...ion/jackson/AbstractJacksonAutomatedExtension.java 92.30% <92.30%> (ø) 2.00 <2.00> (?)
...kson/DefaultJsonNodeJacksonAutomatedExtension.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...ion/spotify/AbstractSpotifyAutomatedExtension.java 100.00% <0.00%> (+11.11%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d9e80...62e11a1. Read the comment docs.

@boretti Codacy Production
Copy link
Member Author

boretti commented May 22, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/main/java/ch/powerunit/extensions/matchers/provideprocessor/extension/jackson/DefaultJsonNodeJacksonAutomatedExtension.java  1
- src/main/java/ch/powerunit/extensions/matchers/provideprocessor/extension/jackson/AbstractJacksonAutomatedExtension.java  1

See the complete overview on Codacy

@boretti Codacy Production
Copy link
Member Author

boretti commented May 22, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/main/java/ch/powerunit/extensions/matchers/provideprocessor/extension/jackson/AbstractJacksonAutomatedExtension.java  1
- src/main/java/ch/powerunit/extensions/matchers/provideprocessor/extension/jackson/DefaultJsonNodeJacksonAutomatedExtension.java  1

See the complete overview on Codacy

@boretti boretti marked this pull request as ready for review May 22, 2020 10:52
@boretti boretti merged commit f801be5 into master May 22, 2020
Version 0.2.0 automation moved this from In progress - Pull request to Done May 22, 2020
@boretti boretti deleted the project/0.2.0/#291 branch May 22, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@boretti boretti

Labels
enhancement
Projects
No open projects
Version 0.2.0
Done
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Add additionnal matcher for Jackson object
2 participants
@boretti @coveralls