Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #331 - Add a way to ignore fields in hasSameValue #332

Merged
merged 1 commit into from May 31, 2020
Merged

Conversation

boretti
Copy link
Member

@boretti boretti commented May 31, 2020

No description provided.

@boretti boretti self-assigned this May 31, 2020
@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #332 into master will increase coverage by 0.05%.
The diff coverage is 98.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   99.20%   99.25%   +0.05%     
==========================================
  Files          79       81       +2     
  Lines        1254     1206      -48     
  Branches       39       36       -3     
==========================================
- Hits         1244     1197      -47     
+ Misses         10        9       -1     
Flag Coverage Δ
#linuxopenjdk10 99.25% <98.86%> (+0.05%) ⬆️
#linuxopenjdk8 99.25% <98.85%> (+0.05%) ⬆️
#linuxoraclejdk9 99.25% <98.86%> (+0.05%) ⬆️
Impacted Files Coverage Δ
...ns/matchers/common/AbstractRoundMirrorSupport.java 100.00% <ø> (ø)
...erunit/extensions/matchers/common/ListJoining.java 100.00% <ø> (ø)
...rocessor/ProvidesMatchersAnnotatedElementData.java 100.00% <ø> (ø)
...deprocessor/fields/CollectionFieldDescription.java 97.29% <66.66%> (ø)
...videprocessor/fields/OptionalFieldDescription.java 96.55% <85.71%> (+0.12%) ⬆️
...ensions/matchers/common/RessourceLoaderHelper.java 100.00% <100.00%> (ø)
...xtensions/matchers/provideprocessor/Matchable.java 100.00% <100.00%> (ø)
...atchers/provideprocessor/NameExtractorVisitor.java 100.00% <100.00%> (ø)
...videprocessor/ProvideMatchersAnnotationMirror.java 100.00% <100.00%> (ø)
...tchers/provideprocessor/ProvideMatchersMirror.java 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fef4d4...66bcb9b. Read the comment docs.

@boretti boretti added this to the 0.3.0 milestone May 31, 2020
@coveralls
Copy link

coveralls commented May 31, 2020

Pull Request Test Coverage Report for Build 2168

  • 96 of 174 (55.17%) changed or added relevant lines in 17 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 58.97%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/ProvideMatchersAnnotationMirror.java 0 1 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/extension/jackson/AbstractJacksonAutomatedExtension.java 0 1 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/ProvidesMatchersSubElementVisitor.java 0 2 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/fields/FieldDescriptionMetaData.java 9 11 81.82%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/Matchable.java 0 3 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/fields/CollectionFieldDescription.java 0 3 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/fields/MapFieldDescription.java 0 3 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/fields/OptionalFieldDescription.java 0 7 0.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/ProvidesMatchersAnnotatedElementMirror.java 9 18 50.0%
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/ProvidesMatchersAnnotatedElementMatcherMirror.java 34 56 60.71%
Files with Coverage Reduction New Missed Lines %
src/main/java/ch/powerunit/extensions/matchers/provideprocessor/ProvidesMatchersAnnotatedElementMirror.java 2 45.71%
Totals Coverage Status
Change from base Build 2145: 1.3%
Covered Lines: 710
Relevant Lines: 1204

💛 - Coveralls

 - Add ignore parameter to hasSameValue
 - Refactor according codacy and codebeat
@boretti boretti added this to In progress in 0.3.0 via automation May 31, 2020
@boretti boretti merged commit ccee2e6 into master May 31, 2020
0.3.0 automation moved this from In progress to Done May 31, 2020
@mergify mergify bot deleted the issue/#331 branch May 31, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants