Allow a NestedModel's model attribute to be specified as a string or an object #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows nested models to be specified as a string so that declaration of model classes are independent of order.
|
If you can add a test I'll merge this in |
|
I'm pretty swamped at the moment, but I'll see what I can do. |
|
Please add in NestedModel example that order of nested models declarations have to be above main model declaration. It took me bunch of time to figure out it. |
|
Are we still interested in merging this in (if it isn't too stale)? If so, I'll add a test so we can get it done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled for a while trying to get NestedModels to work properly. The reason it wasn't working was because my parent model was declared before the nested one. This problem originated from the name of my source files and the fact that I'm using Rails' asset pipeline.
This change allows a model to be specified as a string so that model class declaration order is not important. It should be backwards compatible.
Unfortunately, I have not included tests.