New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap3.js #475
Update bootstrap3.js #475
Conversation
@unti1x why is this needed ? Would we not want to keep the styles ? |
This fix forces bbforms to use standard bs3 css class for bs3 version instead of bs2 |
Looking at the docs. Should this class not be applied to the parent ? is this being added for the padding left ? |
is this a duplicate of #454 ? |
This class should be applied to the parent. It removes ul's bullets from checkbox lists. It's not duplicate of #454. |
For testing powmedia#475 as there is a merge conflict with powmedia#454 and no visible tests.
@exussum12 @unti1x can you look at the version on my branch where I've resolved the merge conflict with #454 - 35cda11 I've also also added examples to the test page and added a field for the radio buttons which should fix issues, but please can you review and we can get all the fixes in? |
(Will also need to rebuild scripts) |
Merged and fixed. |
Sorry, I'm not 100% happy with this - it may be right according to the Bootstrap doc's, but it looks incorrect in the browser. If you merge this patch with my branch https://github.com/glenpike/backbone-forms/tree/unti1x-patch-1 and resolve the conflict in favour of your commit, viewing the ./examples/register-form-custom-template/index.html in a browser (need to serve from backbone-forms root) you will see that the result doesn't look correct. Are you happy try merging that branch into your's or updating your code / adding some checkboxes/radio's to the examples and getting the result looking good? |
Alternate patch for #475 - fixes radio buttons
Fixed with #532 |
fixed classname for checkboxes list