Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap3.js #475

Closed
wants to merge 2 commits into from
Closed

Update bootstrap3.js #475

wants to merge 2 commits into from

Conversation

unti1x
Copy link
Contributor

@unti1x unti1x commented Jul 14, 2015

fixed classname for checkboxes list

@exussum12
Copy link
Collaborator

@unti1x why is this needed ? Would we not want to keep the styles ?

@unti1x
Copy link
Contributor Author

unti1x commented Jan 23, 2016

This fix forces bbforms to use standard bs3 css class for bs3 version instead of bs2

@exussum12
Copy link
Collaborator

Looking at the docs. Should this class not be applied to the parent ?

is this being added for the padding left ?

@exussum12
Copy link
Collaborator

is this a duplicate of #454 ?

@unti1x
Copy link
Contributor Author

unti1x commented Jan 25, 2016

This class should be applied to the parent. It removes ul's bullets from checkbox lists. It's not duplicate of #454.

glenpike pushed a commit to glenpike/backbone-forms that referenced this pull request Jan 26, 2016
For testing powmedia#475 as there is a merge conflict with powmedia#454 and
no visible tests.
@glenpike
Copy link
Collaborator

@exussum12 @unti1x can you look at the version on my branch where I've resolved the merge conflict with #454 - 35cda11

I've also also added examples to the test page and added a field for the radio buttons which should fix issues, but please can you review and we can get all the fixes in?

@glenpike
Copy link
Collaborator

(Will also need to rebuild scripts)

@unti1x
Copy link
Contributor Author

unti1x commented Jan 27, 2016

Merged and fixed. Form.editors.Checkboxes.prototype.className and Form.editors.Radio.prototype.className should be 'list-unslyled' because they are lists and Form.editors.Checkboxe.prototype.className is just item so it's 'checkbox'

@glenpike
Copy link
Collaborator

Sorry, I'm not 100% happy with this - it may be right according to the Bootstrap doc's, but it looks incorrect in the browser.

If you merge this patch with my branch https://github.com/glenpike/backbone-forms/tree/unti1x-patch-1 and resolve the conflict in favour of your commit, viewing the ./examples/register-form-custom-template/index.html in a browser (need to serve from backbone-forms root) you will see that the result doesn't look correct.

Are you happy try merging that branch into your's or updating your code / adding some checkboxes/radio's to the examples and getting the result looking good?

glenpike added a commit that referenced this pull request Oct 12, 2016
Alternate patch for #475 - fixes radio buttons
@glenpike
Copy link
Collaborator

Fixed with #532

@glenpike glenpike closed this Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants